Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various housekeeping tasks #9

Merged
merged 34 commits into from
Dec 6, 2021

Conversation

dougiesquire
Copy link
Collaborator

@dougiesquire dougiesquire commented Nov 30, 2021

This PR includes a range of housekeeping tasks:

  • add LICENSE
  • add setup.py
  • add CONTRIBUTING.md
  • expand .gitignore
  • add versioneer for automatic versioning from git info
  • add pre-commit hooks running black and flake8
  • add github Action running:
    • a tests workflow (pytest including codecov on various platforms and Python versions)
    • a pre-commit workflow
  • add some badges (currently not working as they point at the AusClimateService repo which doesn't have Actions until this PR is merged)

Closes #7

@dougiesquire
Copy link
Collaborator Author

You'll see the pre-commit Action is currently failing. There are a few errors that I have instructed flake8 to ignore in order to get this moving forward (see .pre-commit-config.yaml). However, I didn't want to ignore F821. Ideally we would fix up all the errors flagged by flake8 and then ignore nothing in .pre-commit-config.yaml.

@dougiesquire
Copy link
Collaborator Author

Note I made this branch off of #5, so it's probably best to get that merged first and then merge this.

Copy link
Member

@DamienIrving DamienIrving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dougiesquire!

I'll fix up the conflicts and then merge

@DamienIrving DamienIrving merged commit 5463ac6 into AusClimateService:master Dec 6, 2021
@dougiesquire dougiesquire deleted the housekeeping branch December 14, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up github actions
2 participants