Support for Ufe cameras. #1066
Merged
Support for Ufe cameras. #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2021 13:29
ppt-adsk
reviewed
Jan 12, 2021
lib/mayaUsd/ufe/UsdCameraHandler.h
Outdated
| #pragma once | ||
|
|
||
| #include <mayaUsd/base/api.h> | ||
| #include <mayaUsd/ufe/UsdCamera.h> |
lib/mayaUsd/ufe/UsdCameraHandler.h
Outdated
| namespace MAYAUSD_NS_DEF { | ||
| namespace ufe { | ||
|
|
||
| //! \brief Interface to create a UsdTransform3d interface object. |
There was a problem hiding this comment.
Copy-paste damage in comment.
lib/mayaUsd/ufe/UsdCameraHandler.h
Outdated
| //! Create a UsdCameraHandler. | ||
| static UsdCameraHandler::Ptr create(); | ||
|
|
||
| // Ufe::Transform3dHandler overrides |
lib/mayaUsd/ufe/UsdCamera.h
Outdated
| UsdCamera& operator=(UsdCamera&&) = delete; | ||
|
|
||
| //! Create a UsdCamera. | ||
| static UsdCamera::Ptr create(); |
There was a problem hiding this comment.
Do we need this and its associated setItem() call? Seems like needless complexity otherwise.
|
Logged MAYA-109133 to add automated tests. |
ppt-adsk
approved these changes
Jan 12, 2021
williamkrick
added
the
ready-for-merge
|
Everything is protected by UFE version checks, so this one is safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.