Fixes related to export of skeleton rest-xforms #1130
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ | |
| // | ||
| #include "jointWriter.h" | ||
|
|
||
| #include <mayaUsd/base/debugCodes.h> | ||
| #include <mayaUsd/fileio/primWriter.h> | ||
| #include <mayaUsd/fileio/primWriterRegistry.h> | ||
| #include <mayaUsd/fileio/translators/translatorSkel.h> | ||
|
|
@@ -136,7 +137,6 @@ static GfMatrix4d _GetJointWorldBindTransform(const MDagPath& dagPath) | |
| CHECK_MSTATUS_AND_RETURN(status, GfMatrix4d(1)); | ||
| MPlug plgWorldMatrices = fnNode.findPlug("worldMatrix", false, &status); | ||
| CHECK_MSTATUS_AND_RETURN(status, GfMatrix4d(1)); | ||
| MPlug plgWorldMatrix = plgWorldMatrices.elementByLogicalIndex(membersIdx); | ||
| MObject plgWorldMatrixData = plgWorldMatrix.asMObject(); | ||
| MFnMatrixData fnMatrixData(plgWorldMatrixData, &status); | ||
|
|
@@ -222,16 +222,16 @@ static bool _FindDagPoseMembers( | |
| indices->resize(numDagPaths); | ||
|
|
||
| std::vector<uint8_t> visitedIndices(numDagPaths, 0); | ||
| for (unsigned int i = 0; i < membersPlug.numConnectedElements(); ++i) { | ||
|
There was a problem hiding this comment. I don't mind so much because I think this makes sense (this connection needs to exist anyway to be meaningful so the change will work), but what catches my eye is the reasoning; your comment seems suspicious that somehow There was a problem hiding this comment. Yeah, the thing where it was somehow creating an element was odd. Unfortunately, I didn't have time to fully investigate at the time, and I don't know if I'd be able to replicate now. I guess I also didn't feel too motivated too, since I feel like using There was a problem hiding this comment. Not that big of a deal; if it's not something that you cannot reliably reproduce already, this code is fine as is (IMHO). There was a problem hiding this comment.
|
||
|
|
||
| MPlug memberPlug = membersPlug.connectionByPhysicalIndex(i); | ||
| memberPlug.connectedTo(inputs, /*asDst*/ true, /*asSrc*/ false); | ||
|
|
||
| for (unsigned int j = 0; j < inputs.length(); ++j) { | ||
| MObjectHandle connNode(inputs[j].node()); | ||
| auto it = pathIndexMap.find(connNode); | ||
| if (it != pathIndexMap.end()) { | ||
| (*indices)[it->second] = memberPlug.logicalIndex(); | ||
| visitedIndices[it->second] = 1; | ||
| } | ||
| } | ||
|
|
@@ -241,10 +241,9 @@ static bool _FindDagPoseMembers( | |
| for (size_t i = 0; i < visitedIndices.size(); ++i) { | ||
| uint8_t visited = visitedIndices[i]; | ||
| if (visited != 1) { | ||
| TF_WARN( | ||
| "Node '%s' is not a member of dagPose '%s'.", | ||
| MFnDependencyNode(dagPaths[i].node()).name().asChar(), | ||
| dagPoseDep.name().asChar()); | ||
| return false; | ||
| } | ||
|
|
@@ -254,25 +253,35 @@ static bool _FindDagPoseMembers( | |
|
|
||
| bool _GetLocalTransformForDagPoseMember( | ||
| const MFnDependencyNode& dagPoseDep, | ||
| unsigned int logicalIndex, | ||
| GfMatrix4d* xform) | ||
| { | ||
| MStatus status; | ||
|
|
||
| MPlug xformMatrixPlug = dagPoseDep.findPlug("xformMatrix"); | ||
| if (TfDebug::IsEnabled(PXRUSDMAYA_TRANSLATORS)) { | ||
| // As an extra debug sanity check, make sure that the logicalIndex | ||
| // already exists | ||
| MIntArray allIndices; | ||
| xformMatrixPlug.getExistingArrayAttributeIndices(allIndices); | ||
| if (std::find(allIndices.cbegin(), allIndices.cend(), logicalIndex) == allIndices.cend()) { | ||
| TfDebug::Helper().Msg( | ||
| "Warning - attempting to retrieve %s[%u], but that index did not exist yet", | ||
| xformMatrixPlug.name().asChar(), | ||
| logicalIndex); | ||
| } | ||
| } | ||
| MPlug xformPlug = xformMatrixPlug.elementByLogicalIndex(logicalIndex, &status); | ||
|
There was a problem hiding this comment. Right now I know there's only one call site and the only indices stuffed in here should be the logical ones, but just in case, might be worth having debug assert to check if the logical index actually exists already via There was a problem hiding this comment. My understanding is that if somehow that logical index doesn't exist yet, it will be created... which, as a fallback, seems ok to me. There was a problem hiding this comment. Ok, added a check... |
||
| CHECK_MSTATUS_AND_RETURN(status, false); | ||
|
|
||
| MObject plugObj = xformPlug.asMObject(MDGContext::fsNormal, &status); | ||
| CHECK_MSTATUS_AND_RETURN(status, false); | ||
|
|
||
| MFnMatrixData plugMatrixData(plugObj, &status); | ||
| CHECK_MSTATUS_AND_RETURN(status, false); | ||
|
|
||
| *xform = GfMatrix4d(plugMatrixData.matrix().matrix); | ||
| return true; | ||
| } | ||
|
|
||
| /// Get local-space bind transforms to use as rest transforms. | ||
|
|
@@ -286,11 +295,12 @@ static bool _GetJointLocalRestTransformsFromDagPose( | |
| // Use whatever bindPose the root joint is a member of. | ||
| MObject bindPose = _FindBindPose(rootJoint); | ||
| if (bindPose.isNull()) { | ||
| TF_DEBUG(PXRUSDMAYA_TRANSLATORS) | ||
|
There was a problem hiding this comment. Interested to know why we want to switch this warning to a debug trace? (and same for the one below) There was a problem hiding this comment. Because we now have an additional fallback - we set the I don't mind changing either this or the next one back to Actually - on looking again, I think I'll definitely change the next one back to There was a problem hiding this comment. Changed the second to |
||
| .Msg( | ||
| "%s -- Could not find a dagPose node holding a bind pose: " | ||
| "The Skeleton's 'restTransforms' property will be " | ||
| "calculated from the 'bindTransforms'.\n", | ||
| skelPath.GetText()); | ||
| return false; | ||
| } | ||
|
|
||
|
|
@@ -310,7 +320,7 @@ static bool _GetJointLocalRestTransformsFromDagPose( | |
| TF_WARN( | ||
| "%s -- Failed retrieving the local transform of joint '%s' " | ||
| "from dagPose '%s': The Skeleton's 'restTransforms' " | ||
| "property will be calculated from the 'bindTransforms'.", | ||
| skelPath.GetText(), | ||
| jointDagPaths[i].fullPathName().asChar(), | ||
| bindPoseDep.name().asChar()); | ||
|
|
@@ -320,6 +330,49 @@ static bool _GetJointLocalRestTransformsFromDagPose( | |
| return true; | ||
| } | ||
|
|
||
| /// Set local-space rest transform by converting from the world-space bind xforms. | ||
| static bool | ||
| _GetJointLocalRestTransformsFromBindTransforms(UsdSkelSkeleton& skel, VtMatrix4dArray& restXforms) | ||
| { | ||
| auto bindXformsAttr = skel.GetBindTransformsAttr(); | ||
| if (!bindXformsAttr) { | ||
| TF_WARN("skeleton was missing bind transforms attr: %s", skel.GetPath().GetText()); | ||
| return false; | ||
| } | ||
| VtMatrix4dArray bindXforms; | ||
| if (!bindXformsAttr.Get(&bindXforms)) { | ||
| TF_WARN("error retrieving bind transforms: %s", skel.GetPath().GetText()); | ||
| return false; | ||
| } | ||
|
|
||
| auto jointsAttr = skel.GetJointsAttr(); | ||
| if (!jointsAttr) { | ||
| TF_WARN("skeleton was missing bind joints attr: %s", skel.GetPath().GetText()); | ||
| return false; | ||
| } | ||
| VtTokenArray joints; | ||
| if (!jointsAttr.Get(&joints)) { | ||
| TF_WARN("error retrieving bind joints: %s", skel.GetPath().GetText()); | ||
| return false; | ||
| } | ||
|
|
||
| auto restXformsAttr = skel.GetRestTransformsAttr(); | ||
| if (!restXformsAttr) { | ||
| restXformsAttr = skel.CreateRestTransformsAttr(); | ||
| if (!restXformsAttr) { | ||
| TF_WARN( | ||
| "skeleton had no rest transforms attr, and was unable to " | ||
| "create it: %s", | ||
| skel.GetPath().GetText()); | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| UsdSkelTopology topology(joints); | ||
| restXforms.resize(bindXforms.size()); | ||
| return UsdSkelComputeJointLocalTransforms(topology, bindXforms, restXforms); | ||
| } | ||
|
|
||
| /// Gets the world-space transform of \p dagPath at the current time. | ||
| static GfMatrix4d _GetJointWorldTransform(const MDagPath& dagPath) | ||
| { | ||
|
|
@@ -501,12 +554,15 @@ bool PxrUsdTranslators_JointWriter::_WriteRestState() | |
| _skel.GetBindTransformsAttr(), bindXforms, UsdTimeCode::Default(), _GetSparseValueWriter()); | ||
|
|
||
| VtMatrix4dArray restXforms; | ||
| if (_GetJointLocalRestTransformsFromDagPose(skelPath, GetDagPath(), _joints, &restXforms) | ||
| || _GetJointLocalRestTransformsFromBindTransforms(_skel, restXforms)) { | ||
| UsdMayaWriteUtil::SetAttribute( | ||
| _skel.GetRestTransformsAttr(), | ||
| restXforms, | ||
| UsdTimeCode::Default(), | ||
| _GetSparseValueWriter()); | ||
| } else { | ||
| TF_WARN("Unable to set rest transforms"); | ||
| } | ||
|
|
||
| VtTokenArray animJointNames; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| //Maya ASCII 2020 scene | ||
| //Name: UsdExportSkeletonBindPoseMissingJoints.ma | ||
| //Last modified: Wed, Jan 27, 2021 02:16:36 PM | ||
| //Codeset: UTF-8 | ||
| requires maya "2020"; | ||
| requires "stereoCamera" "10.0"; | ||
| requires "stereoCamera" "10.0"; | ||
| currentUnit -l centimeter -a degree -t film; | ||
| fileInfo "application" "maya"; | ||
| fileInfo "product" "Maya 2020"; | ||
| fileInfo "version" "2020"; | ||
| fileInfo "cutIdentifier" "202011110415-b1e20b88e2"; | ||
| fileInfo "osv" "Linux 3.10.0-1062.18.1.el7.x86_64 #1 SMP Tue Mar 17 23:49:17 UTC 2020 x86_64"; | ||
| fileInfo "UUID" "CA508C80-0000-5159-6011-E644000002A4"; | ||
| createNode transform -n "joint_grp"; | ||
| rename -uid "716A8C80-0000-676C-6011-C976000006DF"; | ||
| createNode joint -n "joint1" -p "joint_grp"; | ||
| rename -uid "716A8C80-0000-676C-6011-C839000006BD"; | ||
| setAttr ".t" -type "double3" -0.13387224879650539 0.21395404220941927 0 ; | ||
| setAttr ".mnrl" -type "double3" -360 -360 -360 ; | ||
| setAttr ".mxrl" -type "double3" 360 360 360 ; | ||
| setAttr ".jo" -type "double3" 0 0 2.5352931362020645 ; | ||
| setAttr ".radi" 0.66868990097983616; | ||
| createNode joint -n "joint2" -p "joint1"; | ||
| rename -uid "716A8C80-0000-676C-6011-C83A000006BE"; | ||
| setAttr ".t" -type "double3" 4.2613380856101655 8.8262730457699945e-15 0 ; | ||
| setAttr ".mnrl" -type "double3" -360 -360 -360 ; | ||
| setAttr ".mxrl" -type "double3" 360 360 360 ; | ||
| setAttr ".jo" -type "double3" 0 0 -50.479340742609303 ; | ||
| setAttr ".radi" 0.60456769613120953; | ||
| createNode joint -n "joint3" -p "joint2"; | ||
| rename -uid "716A8C80-0000-676C-6011-C83A000006BF"; | ||
| setAttr ".t" -type "double3" 3.0216421252033836 6.6613381477509392e-16 0 ; | ||
| setAttr ".mnrl" -type "double3" -360 -360 -360 ; | ||
| setAttr ".mxrl" -type "double3" 360 360 360 ; | ||
| setAttr ".jo" -type "double3" 0 0 47.94404760640726 ; | ||
| setAttr ".radi" 0.60456769613120953; | ||
| createNode joint -n "joint4" -p "joint2"; | ||
| rename -uid "716A8C80-0000-676C-6011-C857000006C2"; | ||
| setAttr ".t" -type "double3" 3.0216421252033836 1.7763568394002505e-15 0 ; | ||
| setAttr ".mnrl" -type "double3" -360 -360 -360 ; | ||
| setAttr ".mxrl" -type "double3" 360 360 360 ; | ||
| setAttr ".jo" -type "double3" 0 0 47.944047606407246 ; | ||
| setAttr ".radi" 0.60456769613120953; | ||
| createNode dagPose -n "dagPose1"; | ||
| rename -uid "716A8C80-0000-676C-6011-C87A000006C4"; | ||
| setAttr -s 3 ".wm"; | ||
| setAttr ".wm[0]" -type "matrix" 0.99902116331496138 0.044234774203348912 0 0 -0.044234774203348912 0.99902116331496138 0 0 | ||
| 0 0 1 0 -0.13387224879650539 0.21395404220941927 0 1; | ||
| setAttr ".wm[1]" -type "matrix" 0.66985600785788646 -0.74249102939813039 0 0 0.74249102939813039 0.66985600785788646 0 0 | ||
| 0 0 1 0 4.1232946827681127 0.40245337023052485 0 1; | ||
| setAttr ".wm[2]" -type "matrix" 1.0000000000000002 2.7755575615628914e-16 0 0 -2.7755575615628914e-16 1.0000000000000002 0 0 | ||
| 0 0 1 0 6.1473598139320718 -1.8410888017844895 0 1; | ||
| setAttr -s 3 ".xm"; | ||
| setAttr ".xm[0]" -type "matrix" "xform" 1 1 1 0 0 0 0 -0.13387224879650539 | ||
| 0.21395404220941927 0 0 0 0 0 0 0 0 0 0 0 | ||
| 0 0 0 0 0 0 0 0 1 0 0 0.022122801416622397 0.9997552608801219 1 | ||
| 1 1 yes; | ||
| setAttr ".xm[1]" -type "matrix" "xform" 1 1 1 0 0 0 0 4.2613380856101655 | ||
| 8.8262730457699945e-15 0 0 0 0 0 0 0 0 0 0 0 | ||
| 0 0 0 0 0 0 0 0 1 0 0 -0.42640567234133786 0.90453203514034353 1 | ||
| 1 1 yes; | ||
| setAttr ".xm[2]" -type "matrix" "xform" 1 1 1 0 0 0 0 3.0216421252033836 | ||
| 6.6613381477509392e-16 0 0 0 0 0 0 0 0 0 0 0 | ||
| 0 0 0 0 0 0 0 0 1 0 0 0.40629053160399503 0.91374394877829046 1 | ||
| 1 1 yes; | ||
| setAttr -s 3 ".m"; | ||
| setAttr -s 3 ".p"; | ||
| connectAttr "joint1.s" "joint2.is"; | ||
| connectAttr "joint2.s" "joint3.is"; | ||
| connectAttr "joint2.s" "joint4.is"; | ||
| connectAttr "joint1.msg" "dagPose1.m[0]"; | ||
| connectAttr "joint2.msg" "dagPose1.m[1]"; | ||
| connectAttr "joint3.msg" "dagPose1.m[2]"; | ||
| connectAttr "dagPose1.w" "dagPose1.p[0]"; | ||
| connectAttr "dagPose1.m[0]" "dagPose1.p[1]"; | ||
| connectAttr "dagPose1.m[1]" "dagPose1.p[2]"; | ||
| // End of UsdExportSkeletonBindPoseMissingJoints.ma |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| //Maya ASCII 2020 scene | ||
| //Name: UsdExportSkeletonBindPoseSparseIndicesTest.ma | ||
| //Last modified: Wed, Jan 27, 2021 02:16:36 PM | ||
| //Codeset: UTF-8 | ||
| requires maya "2020"; | ||
| requires "stereoCamera" "10.0"; | ||
| requires "stereoCamera" "10.0"; | ||
| currentUnit -l centimeter -a degree -t film; | ||
| fileInfo "application" "maya"; | ||
| fileInfo "product" "Maya 2020"; | ||
| fileInfo "version" "2020"; | ||
| fileInfo "cutIdentifier" "202011110415-b1e20b88e2"; | ||
| fileInfo "osv" "Linux 3.10.0-1062.18.1.el7.x86_64 #1 SMP Tue Mar 17 23:49:17 UTC 2020 x86_64"; | ||
| fileInfo "UUID" "CA508C80-0000-5159-6011-E644000002A4"; | ||
| createNode transform -n "joint_grp"; | ||
| rename -uid "716A8C80-0000-676C-6011-C976000006DF"; | ||
| createNode joint -n "joint1" -p "joint_grp"; | ||
| rename -uid "716A8C80-0000-676C-6011-C839000006BD"; | ||
| setAttr ".t" -type "double3" -0.13387224879650539 0.21395404220941927 0 ; | ||
| setAttr ".mnrl" -type "double3" -360 -360 -360 ; | ||
| setAttr ".mxrl" -type "double3" 360 360 360 ; | ||
| setAttr ".jo" -type "double3" 0 0 2.5352931362020645 ; | ||
| setAttr ".radi" 0.66868990097983616; | ||
| createNode joint -n "joint2" -p "joint1"; | ||
| rename -uid "716A8C80-0000-676C-6011-C83A000006BE"; | ||
| setAttr ".t" -type "double3" 4.2613380856101655 8.8262730457699945e-15 0 ; | ||
| setAttr ".mnrl" -type "double3" -360 -360 -360 ; | ||
| setAttr ".mxrl" -type "double3" 360 360 360 ; | ||
| setAttr ".jo" -type "double3" 0 0 -50.479340742609303 ; | ||
| setAttr ".radi" 0.60456769613120953; | ||
| createNode joint -n "joint3" -p "joint2"; | ||
| rename -uid "716A8C80-0000-676C-6011-C83A000006BF"; | ||
| setAttr ".t" -type "double3" 3.0216421252033836 6.6613381477509392e-16 0 ; | ||
| setAttr ".mnrl" -type "double3" -360 -360 -360 ; | ||
| setAttr ".mxrl" -type "double3" 360 360 360 ; | ||
| setAttr ".jo" -type "double3" 0 0 47.94404760640726 ; | ||
| setAttr ".radi" 0.60456769613120953; | ||
| createNode dagPose -n "dagPose1"; | ||
| rename -uid "075DCC80-0000-2CD0-6011-F36F000002EA"; | ||
| setAttr -s 3 ".wm"; | ||
| setAttr ".wm[120]" -type "matrix" 1 0 0 0 0 1 0 0 | ||
| 0 0 1 0 0 0 2 1; | ||
| setAttr ".wm[480]" -type "matrix" 1 0 0 0 0 1 0 0 | ||
| 0 0 1 0 0 3 2 1; | ||
| setAttr ".wm[801]" -type "matrix" 1 0 0 0 0 1 0 0 | ||
| 0 0 1 0 5 3 2 1; | ||
| setAttr -s 4 ".xm"; | ||
| setAttr ".xm[0]" -type "matrix" "xform" 1 1 1 0 0 0 0 777 | ||
| 888 999 0 0 0 0 0 0 0 0 0 0 | ||
| 0 0 0 0 0 0 0 0 1 0 0 0 1 1 | ||
| 1 1 yes; | ||
| setAttr ".xm[120]" -type "matrix" "xform" 1 1 1 0 0 0 0 0 | ||
| 0 2 0 0 0 0 0 0 0 0 0 0 | ||
| 0 0 0 0 0 0 0 0 1 0 0 0 1 1 | ||
| 1 1 yes; | ||
| setAttr ".xm[480]" -type "matrix" "xform" 1 1 1 0 0 0 0 0 | ||
| 3 0 0 0 0 0 0 0 0 0 0 0 | ||
| 0 0 0 0 0 0 0 0 1 0 0 0 1 1 | ||
| 1 1 yes; | ||
| setAttr ".xm[801]" -type "matrix" "xform" 1 1 1 0 0 0 0 5 | ||
| 0 0 0 0 0 0 0 0 0 0 0 0 | ||
| 0 0 0 0 0 0 0 0 1 0 0 0 1 1 | ||
| 1 1 yes; | ||
| setAttr -s 3 ".m"; | ||
| setAttr -s 3 ".p"; | ||
| connectAttr "joint1.s" "joint2.is"; | ||
| connectAttr "joint2.s" "joint3.is"; | ||
| connectAttr "joint1.msg" "dagPose1.m[120]"; | ||
| connectAttr "joint2.msg" "dagPose1.m[480]"; | ||
| connectAttr "joint3.msg" "dagPose1.m[801]"; | ||
| connectAttr "dagPose1.w" "dagPose1.p[120]"; | ||
| connectAttr "dagPose1.m[120]" "dagPose1.p[480]"; | ||
| connectAttr "dagPose1.m[480]" "dagPose1.p[801]"; | ||
| // End of UsdExportSkeletonBindPoseSparseIndicesTest.ma |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| //Maya ASCII 2020 scene | ||
| //Name: UsdExportSkeletonNoDagPose.ma | ||
| //Last modified: Wed, Jan 27, 2021 05:20:36 PM | ||
| //Codeset: UTF-8 | ||
| requires maya "2020"; | ||
| requires "stereoCamera" "10.0"; | ||
| currentUnit -l centimeter -a degree -t film; | ||
| fileInfo "application" "maya"; | ||
| fileInfo "product" "Maya 2020"; | ||
| fileInfo "version" "2020"; | ||
| fileInfo "cutIdentifier" "202011110415-b1e20b88e2"; | ||
| fileInfo "osv" "Linux 3.10.0-1062.18.1.el7.x86_64 #1 SMP Tue Mar 17 23:49:17 UTC 2020 x86_64"; | ||
| fileInfo "UUID" "075DCC80-0000-2CD0-6012-11640000043B"; | ||
| createNode transform -n "skel_root"; | ||
| rename -uid "075DCC80-0000-2CD0-6012-11480000043A"; | ||
| createNode joint -n "joint1" -p "skel_root"; | ||
| rename -uid "075DCC80-0000-2CD0-6012-0D7900000396"; | ||
| addAttr -ci true -sn "liw" -ln "lockInfluenceWeights" -min 0 -max 1 -at "bool"; | ||
| setAttr ".t" -type "double3" -8 1 7 ; | ||
| setAttr ".r" -type "double3" 0 60 0 ; | ||
| setAttr ".bps" -type "matrix" -1 0 0 0 0 1 0 0 | ||
| 0 0 -1 0 0 0 0 1; | ||
| createNode joint -n "joint2" -p "joint1"; | ||
| rename -uid "075DCC80-0000-2CD0-6012-0D7E00000397"; | ||
| addAttr -ci true -sn "liw" -ln "lockInfluenceWeights" -min 0 -max 1 -at "bool"; | ||
| setAttr ".t" -type "double3" -3 0 1.23 ; | ||
| setAttr ".r" -type "double3" 30 0 0 ; | ||
| setAttr ".bps" -type "matrix" 0 -1 0 0 -1 0 0 0 | ||
| 0 0 -1 0 3 0 0 1; | ||
| createNode joint -n "joint3" -p "joint2"; | ||
| rename -uid "075DCC80-0000-2CD0-6012-0D94000003A6"; | ||
| addAttr -ci true -sn "liw" -ln "lockInfluenceWeights" -min 0 -max 1 -at "bool"; | ||
| setAttr ".t" -type "double3" -5 5 13 ; | ||
| setAttr ".r" -type "double3" 45 0 45 ; | ||
| setAttr ".bps" -type "matrix" 0 -1 0 0 0 0 -1 0 | ||
| 1 0 0 0 3 0 -2 1; | ||
| createNode joint -n "joint4" -p "joint3"; | ||
| rename -uid "075DCC80-0000-2CD0-6012-0E6A000003FD"; | ||
| addAttr -ci true -sn "liw" -ln "lockInfluenceWeights" -min 0 -max 1 -at "bool"; | ||
| setAttr ".t" -type "double3" 0 1.9999999999999998 4.4408920985006262e-16 ; | ||
| setAttr ".r" -type "double3" 90 0 0 ; | ||
| setAttr ".bps" -type "matrix" 0 -1 0 0 1 0 0 0 | ||
| 0 0 1 0 3 0 -4 1; | ||
| connectAttr "joint1.s" "joint2.is"; | ||
| connectAttr "joint2.s" "joint3.is"; | ||
| connectAttr "joint3.s" "joint4.is"; | ||
| // End of UsdExportSkeletonNoDagPose.ma |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment on why this check wasn't good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because
membersIdxis a logical index, whilenumElements()gives the number of physical plugs... so the two aren't related.