MAYA-108563 - Support default material shading using new SDK APIs #1339
Conversation
Draws correctly, but selection fails to update in default material repr.
JGamache-autodesk
added
bug
|
Incomplete. One item remaining: selection does not update when dealing with the default material repr. |
JGamache-autodesk
removed
the
do-not-merge-yet
JGamache-autodesk
changed the title
| @@ -1597,7 +1642,8 @@ void HdVP2Mesh::_UpdateDrawItem( | |||
| } | |||
| #endif | |||
|
|
|||
| if (desc.geomStyle == HdMeshGeomStyleHull) { | |||
| if (desc.geomStyle == HdMeshGeomStyleHull | |||
| && desc.shadingTerminal == HdMeshReprDescTokens->surfaceShader) { | |||
There was a problem hiding this comment.
defaultMaterial repr has a different shading terminal and will skip the shading update.
Regular smoothMesh has "surfaceShader" as terminal, so this addition does not require version check.
There was a problem hiding this comment.
If we modify the real material while in default material mode does it update correctly when we turn off "use default material"? IIRC somewhere we clear all the dirty flags, so we'd forget about the dirty material id and then not update.
JGamache-autodesk
added
do-not-merge-yet
|
Done and working, but can not be run thru preflight until some Maya updates are integrated. |
JGamache-autodesk
removed
the
do-not-merge-yet
…l_shading_mode # Conflicts: # lib/mayaUsd/render/vp2RenderDelegate/mesh.cpp
| if (reprToken == HdReprTokens->smoothHull | ||
| || reprToken == HdVP2ReprTokens->defaultMaterial) { | ||
| // Share selection highlight render item between smoothHull and defaultMaterial: | ||
| bool foundShared = false; |
There was a problem hiding this comment.
If we end up using this pattern to share more render items then this seems like a good candidate to be refactored into a method.
| @@ -1597,7 +1642,8 @@ void HdVP2Mesh::_UpdateDrawItem( | |||
| } | |||
| #endif | |||
|
|
|||
| if (desc.geomStyle == HdMeshGeomStyleHull) { | |||
| if (desc.geomStyle == HdMeshGeomStyleHull | |||
| && desc.shadingTerminal == HdMeshReprDescTokens->surfaceShader) { | |||
There was a problem hiding this comment.
If we modify the real material while in default material mode does it update correctly when we turn off "use default material"? IIRC somewhere we clear all the dirty flags, so we'd forget about the dirty material id and then not update.
kxl-adsk
deleted the
t_gamaj/MAYA-108563/implement_kDefaultMaterial_shading_mode
branch
In #1339 code was added to share the selection render item between reprs. The code did not track usage, so as soon as one of the reprs is removed, the render item was removed from the subscene as well, leaving dangling pointers in the remaining reprs. In #1597 code was added that seem to indicate there was suspicion about render item issues, but sharing was not identified as the cause. This PR adds use count tracking to the render item so they only get removed from the subscene once all reprs have stopped using the shared render item.
Draws correctly, but selection fails to update in default material repr.