MAYA-112834 Make sure that the render item name stored in HdVP2DrawItem exactly … #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atches the name of the MRenderItem.
williamkrick
commented
Jul 23, 2021
| @@ -61,11 +61,9 @@ HdVP2DrawItem::AddRenderItem(MHWRender::MRenderItem* item, const HdGeomSubset* g | |||
| RenderItemData& renderItemData = _renderItems.back(); | |||
|
|
|||
| renderItemData._renderItem = item; | |||
| renderItemData._renderItemName = _drawItemName; | |||
| renderItemData._renderItemName = item->name(); | |||
There was a problem hiding this comment.
The name stored in the _renderItemData must exactly match the name of the MRenderItem. We use the name to remove the item from the subscene container. If the names do not match we'll leak items into the container and forget about them.
There was a problem hiding this comment.
Actually I changed the code a bit more so that we don't rely on _renderItemName. That member is meant for debugging only.
JGamache-autodesk
approved these changes
Jul 23, 2021
williamkrick
added
ready-for-merge
JGamache-autodesk
added a commit
that referenced
this pull request
Oct 18, 2022
In #1339 code was added to share the selection render item between reprs. The code did not track usage, so as soon as one of the reprs is removed, the render item was removed from the subscene as well, leaving dangling pointers in the remaining reprs. In #1597 code was added that seem to indicate there was suspicion about render item issues, but sharing was not identified as the cause. This PR adds use count tracking to the render item so they only get removed from the subscene once all reprs have stopped using the shared render item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matches the name of the MRenderItem.