-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-112228 Use Adaptors for custom schema import-export #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds custom API schema importers and exporter capabilities to existing UsdMayaAdaptor class. This can be done two ways: - For simple attribute-to-attribute mapping we offer a way to Apply/Remove/Edit schemas using custom generated UsdMayaAttributeAdaptor - For more complex work, we offer a copyToPrim and copyFromPrim callbacks that allow doing all the import/export work in a single function call The schema API export and import call have been augmented to support animation, and an apiSchemas parameter was added to import job the replicate the export workflow. Added the concept of jobContext to import and export code paths. These contexts can be registered at will and will add/modify import and export job context parameters Added Python wrappers for these new concepts An example of use can be found in the test\lib\usd\translators\testUsdExportSchemaApi.py unit test.
kxl-adsk
reviewed
Nov 12, 2021
kxl-adsk
reviewed
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, Jerry. My last comment will be only about documentation - we will need to help developers discover how to work with API schema adaptor plugins. A white paper that describes the unit test could be a great start.
kxl-adsk
approved these changes
Nov 16, 2021
JGamache-autodesk
added
the
ready-for-merge
Development process is finished, PR is ready for merge
label
Nov 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
import-export
Related to Import and/or Export
ready-for-merge
Development process is finished, PR is ready for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom API schema importers and exporter capabilities to existing UsdMayaAdaptor class. This can be done two ways:
The schema API export and import call have been augmented to support animation, and an apiSchemas parameter was added to import job the replicate the export workflow.
Added the concept of jobContext to import and export code paths.
These contexts can be registered at will and will add/modify import and export job context parameters
Added Python wrappers for these new concepts
An example of use can be found in the test\lib\usd\translators\testUsdExportSchemaApi.py unit test.