Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API writers #2557

Closed
wants to merge 2 commits into from
Closed

Add API writers #2557

wants to merge 2 commits into from

Conversation

dj-mcg
Copy link
Collaborator

@dj-mcg dj-mcg commented Aug 22, 2022

Some Maya nodes may not correspond directly to Usd prims. One example of
this is Renderman-For-Maya's PxrMeshLight, which should be exported as
an applied MeshLightAPI on a Mesh prim.

To support this, this change adds an apiWriterRegistry that allows us to
register apiWriters that get run for each exported prim. We also want to
prevent the export from creating a node for these Maya nodes, so we now
allow a type to be registered as a type that should not result in a Usd
prim.

Some Maya nodes may not correspond directly to Usd prims. One example of
this is Renderman-For-Maya's PxrMeshLight, which should be exported as
an applied MeshLightAPI on a Mesh prim.

To support this, this change adds an apiWriterRegistry that allows us to
register apiWriters that get run for each exported prim. We also want to
prevent the export from creating a node for these Maya nodes, so we now
allow a type to be registered as a type that should not result in a Usd
prim.
@seando-adsk
Copy link
Collaborator

Hi @dj-mcg we had an internal discussion and our devs had some comments/questions. It like this PR could be reimplementing the API schema adapters which was introduced in #1814 and documented in SchemaAPI_Import_Export_in_Python. Could you have a look and tell us what is missing and if you would be willing to add the missing pieces.

There was also some questions raised:

  • How does this affect backward compatibility? If users assumed a given USD output from a scene, how is this changing their existing output?
  • Can't a prim support multiple APIs? How is export handled in that case?
  • How is this affecting our edit as Maya workflow?

Thanks, Sean

@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Sep 6, 2022

Thanks for carefully thinking through all of this, @seando-adsk - Hold for now, let me follow up with the team to discuss and will follow up.

@mrawde
Copy link
Contributor

mrawde commented Sep 16, 2022

Hi! Thanks for the feedback. I took a look at the schemaApiAdaptor and we can get this working for the most part. I filed some related issues:

#2605
#2606
#2607

@dj-mcg dj-mcg closed this Sep 16, 2022
@dj-mcg dj-mcg deleted the pr/API_Schema_Export branch September 16, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants