[al] Mark outTime attribute dirty to force updating Maya bbox; fix incorrect time code for bbox #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect time code for bbox
williamkrick
approved these changes
Apr 6, 2022
| @@ -1605,6 +1605,7 @@ MStatus ProxyShape::compute(const MPlug& plug, MDataBlock& dataBlock) | |||
| m_requestedRedraw = true; | |||
| MTime currentTime; | |||
| if (plug == outTime()) { | |||
| MHWRender::MRenderer::setGeometryDrawDirty(thisMObject()); | |||
There was a problem hiding this comment.
I see that you don't call MayaUsdProxyShapeBase and that the implementation of the two compute() methods has drifted relatively far apart.
- I believe that
MayaUsdProxyShapeBase::computeis already doing the right thing by testing if the computed plug is timeAttr, assuming that plug must be computed in order to compute outTimeAttr. Is my understanding correct? - What workflow can be tested to verify that the Maya bbox is correctly updated? Can we write an automated test that will catch this?
- Is there anything in
MayaUsdProxyShapeBase::computethat you should copy here? There is some code to support changing which purposes the proxy shape is displaying which could be relevant to you.
There was a problem hiding this comment.
@williamkrick , those are good questions, I am pretty sure there must be good reasons to be implemented in that way in the first place, however I don't think I am the right person to give you an answer :-(
|
@seando-adsk I have some questions but nothing that would prevent this from being merged. |
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for this PR: