Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMSUSD-1066 - Minimal API needed by LookdevX to decouple from mayaUsd #3608

Merged
merged 4 commits into from
Feb 20, 2024
Merged

EMSUSD-1066 - Minimal API needed by LookdevX to decouple from mayaUsd #3608

merged 4 commits into from
Feb 20, 2024

Conversation

gz-adsk
Copy link

@gz-adsk gz-adsk commented Feb 13, 2024

This will remove the need for LookdevX to link directly to mayaUsd and mayaUsdUtils with a couple of exceptions that will be sorted out at a later time.

gz-adsk added 2 commits February 12, 2024 14:05
EMSUSD-1066 - Minimal API needed by LookdevX to decouple from mayaUsd
4f201d3
EMSUSD-1016 - Code Review:
01f1f60 
* Date fixes.
* Removal of handler functions as their use is temporary and only for
  tests
* Clarification for commands that they are not executed.
@gz-adsk gz-adsk requested a review from seando-adsk February 13, 2024 15:03
@gz-adsk gz-adsk self-assigned this Feb 13, 2024
@gz-adsk gz-adsk assigned gz-adsk and unassigned gz-adsk Feb 13, 2024
@gz-adsk gz-adsk marked this pull request as draft February 13, 2024 16:57
@gz-adsk gz-adsk assigned gz-adsk and unassigned gz-adsk Feb 13, 2024
@gz-adsk gz-adsk marked this pull request as ready for review February 13, 2024 18:28
@gz-adsk gz-adsk changed the title Minimal API needed by LookdevX to decouple from mayaUsd EMSUSD-1066 - Minimal API needed by LookdevX to decouple from mayaUsd Feb 13, 2024
seando-adsk
seando-adsk approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this new utils should have a python wrapper and have some kind of minimal unit tests. I'm okay with this PR going in now as long as we come back later and add the wrapper and tests.

@seando-adsk seando-adsk added the build Related to building maya-usd repository label Feb 14, 2024
@gz-adsk gz-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 14, 2024
@seando-adsk seando-adsk merged commit ccfefed into dev Feb 20, 2024
11 checks passed
@seando-adsk seando-adsk deleted the gz-adsk/EMSUSD-1016/mayausdapi-for-lookdevx branch February 20, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seando-adsk seando-adsk seando-adsk approved these changes

Assignees

@gz-adsk gz-adsk

Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gz-adsk @seando-adsk