EMSUSD-998 better universal manip undo redo #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
bug
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-998/better-universal-manip-undo-redo
branch
from
d741212 to
f0a5fd4
Compare
Fix the complicated handling of undo and redo vs the universal manipulator. The code failed to do the right thing when half of the attributes are already existed or when more complex composite manipulations were done, for example when scaling with the universal manipulator. We make the transformation commands more robust vs the ordering of calls to support all use cases. They still handle the bug related to object-space translation redo: when redoing an object-space translation, Maya passes in incorrect values to the command that must be ignored. Apply fix to all transform commands. This way they all use the same pattern from UsdSetXformOpUndoableCommandBase to manage any order of calls to execute/set/undo/redo: use in the CommonAPI commands, matrix commands and Maya tranform-stack commands.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-998/better-universal-manip-undo-redo
branch
from
f0a5fd4 to
7302fd0
Compare
pierrebai-adsk
commented
Feb 15, 2024
| @@ -479,32 +425,33 @@ UsdTransform3dMayaXformStack::rotateCmd(double x, double y, double z) | |||
| GfVec3f v(x, y, z); | |||
| CvtRotXYZToAttrFn cvt = hasRotate ? getCvtRotXYZToAttrFn(op.GetOpName()) : toXYZ; | |||
|
|
|||
There was a problem hiding this comment.
For the changes below, I suggest you "Hide whitespace" in the diff preferences, under the cog at the top of the review page.
AramAzhari-adsk
approved these changes
Feb 20, 2024
pierrebai-adsk
added
the
ready-for-merge
ppt-adsk
approved these changes
Mar 8, 2024
| if (!_isPrepared) | ||
| return; | ||
|
|
||
| // Restore the initial value and potentially remove the creatd attributes. |
| _newOpValue = v; | ||
|
|
||
| // Set the new value, potentially creating the attribute if it | ||
| // did not exists or caching the initial value if this is the |
There was a problem hiding this comment.
Nit-pick: "exists" --> "exist".
Comment on lines
+124
to
+128
| if (!_isPrepared) | ||
| return; | ||
|
|
||
| if (_opCreated) | ||
| return; |
There was a problem hiding this comment.
This feels like you're going from a unique _state description to multiple booleans, which I'm not crazy about. Representing state uniquely and having clear transitions from one state to another usually helps maintainability, but I trust you on this one.
| // undo an attribute creation if it was not yet created. | ||
| // | ||
| // - Maya can call undo and set-value before first executing the | ||
| // command. In particular, when using manipualtion tools, Maya |
There was a problem hiding this comment.
Nit-pick: "manipualtion".
seando-adsk
added
ufe
seando-adsk
deleted the
bailp/EMSUSD-998/better-universal-manip-undo-redo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the complicated handling of undo and redo vs the universal manipulator. The code failed to do the right thing when half of the attributes are already existed or when more complex composite manipulations were done, for example when scaling with the universal manipulator.
We make the transformation commands more robust vs the ordering of calls to support all use cases. They still handle the bug related to object-space translation redo: when redoing an object-space translation, Maya passes in incorrect values to the command that must be ignored.
Apply fix to all transform commands. This way they all use the same pattern from UsdSetXformOpUndoableCommandBase to manage any order of calls to execute/set/undo/redo: use in the CommonAPI commands, matrix commands and Maya tranform-stack commands.