Pixar Mesh write translator/utilities refactoring #420
Conversation
…il namespace so they are accessible for others.
…doesn't do much work at the moment ) - Created meshWriteUtils that houses utility functions operating on writing mesh data. - Moved below utility functions from meshReadUtils to meshWriteUtils since they operate on write. GetMeshNormals() GetSubdivScheme() GetSubdivInterpBoundary() GetSubdivFVLinearInterpolation() - Moved isMeshValid() and _exportReferenceMesh() to meshWriteUtils
…DivTagsToUSDPrim - Created two new template functions for writing attribute values. These functions now take UsdUtilsSparseValueWriter by reference and eventually would replace _SetAttribute functions in UsdMayaPrimWriter. Note: Pixar uses UsdUtilsSparseValueWriter Utility class that manages sparse authoring of a set of UsdAttributes. UsdUtilsSparseAttrValueWriter is A utility class for authoring time-varying attribute values with simple run-length encoding, by skipping any redundant time-samples.
- vertex position - face/vertex indices - invisible faces Removed the "TODO: Use memcpy()" and used memcpy to copy the data directly.
…ointUtil) that houses functions for writing out joint and skin data. This work had to be done since writing skinning data happens during writeMeshAttrs call. There are more work needs to be done to make this utilities reusable in other places but this is outside the scope of this PR.
cameraWriter instancerWriter jointWriter nurbsCurveWriter nurbsSurfaceWriter particleWriter
- vertex position - face/vertex indices - invisible faces Removed the "TODO: Use memcpy()" and used memcpy to copy the data directly.
HamedSabri-adsk
added
core
There was a problem hiding this comment.
Thanks @HamedSabri-adsk! The change looks great to me, but I just had one request to use the newly public getDagPath() in UsdMayaWriteJobContext::CreatePrimWriter() as well.
- update the namespace - rename writeVertexData to writePointsData
…of templated VtArray.
…te_part2 PR II: Pixar Mesh write translator/utilities refactoring
…YA-101460/pxr_mesh_write_part1
HamedSabri-adsk
added
the
do-not-merge-yet
…ny where, there is no test case around it, and original logic shouldn't have worked.
HamedSabri-adsk
removed
the
do-not-merge-yet
|
|
||
| void wrapMeshWriteUtils() | ||
| { | ||
| // TODO: HS, June 11, 2020 This logics is not accurate. Revisit this later. | ||
| // There are no test cases around is not being consumed in any tests. | ||
| /* | ||
| scope s = class_<DummyScopeClass>("MeshWriteUtils", no_init) | ||
|
|
||
| .def("GetMeshNormals", &_GetMeshNormals) | ||
| .staticmethod("GetMeshNormals") | ||
|
|
||
| ; | ||
| */ |
There was a problem hiding this comment.
@HamedSabri-adsk: Can you please revert this change? True that the Python bindings for this are not used anywhere in maya-usd, but we have internal code that does this (using the old name):
from pxr.UsdMaya import MeshUtil
(normalsArray, interpolation) = MeshUtil.GetMeshNormals(...)There was a problem hiding this comment.
Hey @mattyjams Sure will do. But before that I want to understand a few things:
1-
I can see in the original code that GetMeshNormals is not a static function and yet it in the python binding is declared as staticmethod. I am not an expert in Boost python binding but curious how this works?
PixarAnimationStudios/OpenUSD@be80acc
2- MeshUtil has now renamed MeshWriteUtils. I had to fix it in this commit:
Does this mean that we should revert these name changes as well?
There was a problem hiding this comment.
For #1, we're binding MeshWriteUtils.GetMeshNormals() in Python to the _GetMeshNormals() function declared just above in wrapMeshWriteUtils.cpp, which is indeed declared static, and returns a boost tuple type:
For #2, we do want the name changes so that files/classes/etc. are all in alignment, so that part should not be reverted. We can absorb the name change no problem, we just need a function with the new name to exist so that we can switch to it. :P
There was a problem hiding this comment.
@mattyjams Gotcha... see be3c545
…t used any where, there is no test case around it, and original logic shouldn't have worked." This reverts commit 5803a46.
After PR Autodesk#420, the crease sharpnesses were incorrectly being populated using the edge IDs.
…_export fix for exporting mesh crease sharpnesses following PR #420
PR Description
This PR is the continuation of work on refactoring mesh translator/utilities in PR #343.
This PR involves refactoring Pixar's mesh writer class ( PxrUsdTranslators_MeshWriter ) by creating utilities and providing a simpler interface:
UsdMayaMeshWriteUtilsnamespace.UsdUtilsSparseValueWriteris now directly passed as an optional argument to all utility functions responsible for writing mesh data.UsdMayaJointUtilnamespace.