[mtoh] Split pre and post scene passes so camera guides go above Hydra. #526
Conversation
| } | ||
|
|
||
| MHWRender::MClearOperation& clearOperation() override { | ||
| mClearOperation.setMask(MHWRender::MClearOperation::kClearNone); | ||
| return mClearOperation; | ||
| } | ||
|
|
||
| MSceneFilterOption renderFilterOverride() override { | ||
| return MSceneFilterOption(MHWRender::MSceneRender::renderFilterOverride() | kRenderPostSceneUIItems); |
There was a problem hiding this comment.
Can you return kRenderPostSceneUIItems directly? From API doc, MSceneRender::renderFilterOverride() returns kNoSceneFilterOverride which equals 0.
| @@ -66,13 +66,17 @@ class HdMayaManipulatorRender : public MHWRender::MSceneRender { | |||
| : MHWRender::MSceneRender(name) {} | |||
|
|
|||
| MUint64 getObjectTypeExclusions() override { | |||
| return ~MHWRender::MFrameContext::kExcludeManipulators; | |||
| return MHWRender::MSceneRender::getObjectTypeExclusions() | ~(kExcludeManipulators | kExcludeHoldOuts); | |||
There was a problem hiding this comment.
Is this change relevant to the issue? Why do you exclude holdouts?
MHWRender::MSceneRender::getObjectTypeExclusions() returns 0, so there is no need to use it in the bitmask op.
|
I don't know well enough about mtoh implementation to review the impact to any existing workflow, adding @elrond79 to review too. |
|
I just called through to the base classes as I didn't know they returned 0. So I can test to see if removing them still works. The other change is relevant, as kExcludeHoldOuts is what winds up drawing the camera guides from what I've seen. |
|
Yes, a bit odd. Maybe adding a comment to explain the purpose of excluding holdout would be better. |
@marsupial How is the test doing? |
|
Sadly no time! Monday for sure. |
marsupial
force-pushed
the
PR/mtoh-cam-guides
branch
from
0dd4077 to
aeb87c4
Compare
|
@marsupial I see you (force) pushed changes two days ago to the branch in your fork. We are not receiving notification for this action from GitHub. For future PRs, please leave a comment in the PR when reviewers should review new changes...or you can re-request the review from a specific person which will send a notification. |
#525