Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable shadows on the directionalLight in the Maya scene for the testProxyShapeDrawColorAccuracy test #815

Commits on Oct 2, 2020

  1. disable shadows on the directionalLight in the Maya scene for the tes…

    …tProxyShapeDrawColorAccuracy test
    
    The Storm-based Pixar batch renderer (poorly) supports depth map shadows but not
    ray-traced shadows, while the Viewport 2.0 render delegate supports both. The
    directionalLight in the Maya scene for the testProxyShapeDrawColorAccuracy test
    was set to use ray-traced shadows (which is the default). This meant that the
    "all_lights" image written by the test would not include shadows when run with
    the Pixar batch renderer, but it would include a very noisy shadow when run
    with the Viewport 2.0 render delegate, since the geometry is just a very simple
    cube.
    
    Shadows are not important in the functionality being exercised by this test, so
    this change simply disables shadows on the directionalLight.
    mattyjams committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    16cdc83 View commit details
    Browse the repository at this point in the history