Transform Gizmos on Mirabuf Assemblies #1009
Conversation
Made the functions only run once by putting them in the event listener
Dhruv-0-Arora
requested review from
PepperLola and
BrandonPacewic
and removed request for
a team
Dhruv-0-Arora
added
physics
|
Right now it does not set Rotation or Scale. Only position |
…same object and also implemented physics being disabled only for the one object need to implement esc listener to escape the transform gizmo
…ng branch 'origin/dev' into dhruv/1733/mirabuf-gizmo made a lot of changes with bugs and other issues
|
Completely ready for review |
There was a problem hiding this comment.
I added a quick change to your PR that also sets the bodies to be sensors when disabled, meaning they won't act on generated collision contacts.
When spawning in a field, we should restrict it to translation movement only. Not rotation. I also noticed that after finishing with the gizmo, if I try to move the camera by clicking near the center of the screen, it doesn't work, I have to click on the edge, and then it essentially snaps out of it and I can orbit the camera like normal.
…gizmo' into dhruv/1733/mirabuf-gizmo
Added deattaching transform gizmos from mesh
enables physics for all nodes also removed redudant enabling physics for root node
There was a problem hiding this comment.
Are the negative axis arrows supposed to be partially invisible? Also, I noticed the squares for moving along a plane disappear when the angle between them and the camera is too shallow. Not sure if there's much you can do about that though but I could be wrong.
Dhruv-0-Arora
requested review from
a-crowell and
LucaHaverty
and removed request for
a team
Well I can't really do much about either since it is the built in transform gizmo from three.js. The negative axis arrows being partially invisible is intentional on their end |
| @@ -27,6 +29,17 @@ class MirabufSceneObject extends SceneObject { | |||
| private _debugBodies: Map<string, RnDebugMeshes> | null | |||
| private _physicsLayerReserve: LayerReserve | undefined = undefined | |||
|
|
|||
| private _transformGizmos: TransformGizmos | undefined = undefined | |||
| private _deleteGizmoOnEscape: boolean = true | |||
There was a problem hiding this comment.
I'll let this be for now, but the entirety of transform gizmos needs a major refactor to be more adaptable. It should honestly be worked into some kind of UI component. Jira ticket for refactoring
Description
This branch adds transform gizmos to the mirabuf assemblies as they spawn in. These transform gizmos currently are always on the Mirabuf assemblies as they spawn. The physics system is disabled when the user presses the transform gizmo (will implement so physics is disabled for only the one assembly and also it stays disable as long as the gizmo is attached).
JIRA Issue