Intake and Ejector Configurator #1017

Dhruv-0-Arora · 2024-07-09T00:32:23Z

Description

Implementation of configuring the positioning of a robot's intake and ejector. Uses raycasting to detect the node (very basic implementation of detecting node) and saves the information. Allows user to scale the size of the sphere that spawns as well.

Features

Robot with configured pickup zone

Robot holding a Game Piece

Intake Configuration

Ejector Configuration

Temporary Components

These components are going to be left in and will be addressed shortly after in the scoring zone branch and likely one more branch to address input and behavior issues.

Pieces are picked up via a ray cast from the intake zone, 3 meters forward along the z axis.
Ejection is bound to left shift and control and isn't compatible with the InputSystem
Pickup zones are always rendered
There is no highlighting of rigid nodes

Warning

Merge after #1007

JIRA Issue

Need to merge transform gizmo code to add a sphere in the scene for implementation.

…hruv/1728/intake-ejector-config

…r-config

…hruv/1728/intake-ejector-config

…r-config

Removing duplicate line of code after merge

…into dhruv/1728/intake-ejector-config

…r-config

…tor-config

azaleacolburn · 2024-07-09T15:49:24Z

fission/src/mirabuf/MirabufSceneObject.ts

+    private EnablePhysics() {
+        this._mirabufInstance.parser.rigidNodes.forEach(rn => {
+            World.PhysicsSystem.EnablePhysicsForBody(this._mechanism.GetBodyByNodeId(rn.id)!)
+        })
+    }


Why is this a function, but disabling physics for all rigid bodies in the same way isn't? It's not an issue, I'm just curious.

I added that to solve a bug so that is a good point and ill add that. The problem is that all of that stuff is from PR #1009 so I might need to wait for that to be merged

azaleacolburn · 2024-07-09T15:51:44Z

fission/src/systems/physics/PhysicsSystem.ts

+    /**
+     * Enabing physics for a single body
+     *
+     * @param bodyId
+     */
+    public EnablePhysicsForBody(bodyId: Jolt.BodyID) {
+        this._joltBodyInterface.ActivateBody(bodyId)
+        this.GetBody(bodyId).SetIsSensor(false)
+    }


5 lines of comments, 4 lines of code. This is what programming's all about. To be honest, these functions are completely self-documenting without any comments.

I don't even know why I did that but I do know its gone from #1009 😇

fission/src/systems/physics/PhysicsSystem.ts

azaleacolburn · 2024-07-09T16:17:31Z

fission/src/systems/scene/SceneRenderer.ts

-                    if (isDragging) {
-                        return
-                    }
+                if (!event.value && !Array.from(this.transformControls.keys()).some(tc => tc.dragging)) {


Extracting this operation to a variable might be nice

That is true it would be more optimized

…into dhruv/1728/intake-ejector-config

…hruv/1728/intake-ejector-config

…r-config

need to fix bug of onCancel function not being run when another MainHUD panel being opened

HunterBarclay · 2024-07-15T16:17:38Z

@Ewie21 Preferences will be merged in first, then this branch, then finally Ayla's branch will have all the glue for everything.

azaleacolburn · 2024-07-15T16:24:46Z

Notes for Reviewers

checkselectednode, listrobots, etc.. are duplicated functions. Where should I put them
Can I optimized this in checkSelectedNode()

selectedRobot?.mirabufInstance?.parser.rigidNodes.forEach(rn => {
            if (World.PhysicsSystem.GetBody(selectedRobot.mechanism.GetBodyByNodeId(rn.id)!).GetID() === body.GetID()) {
                bodyAttachmentRef.current = body
                returnValue = true
            }
        })

You could make it into a regular for loop and break, since all you'll do is set the same variables again. Also, could you just compare the ids directly, or are ids not consistent between Physics System and mechanism? I'm sure there are other things as well, but I haven't throughly read through the code yet.

HunterBarclay · 2024-07-15T16:25:53Z

You could make it into a regular for loop and break, since all you'll do is set the same variables again. Also, could you just compare the ids directly, or are ids not consistent between Physics System and mechanism? I'm sure there are other things as well, but I haven't throughly read through the code yet.

@Ewie21 This no longer exists.

HunterBarclay · 2024-07-15T16:44:23Z

Note: Rigid node highlighting can be implemented once #1023 is merged in.

LucaHaverty · 2024-07-15T17:53:47Z

I'm not sure when this was introduced, but opening the poker panel or settings modal throws this error. It might be anything that uses a slider.

TypeError: Cannot read properties of undefined (reading 'toLocaleString')
    at Slider (Slider.tsx:38:44)
    at renderWithHooks (react-dom.development.js:15486:18)
    at mountIndeterminateComponent (react-dom.development.js:20103:13)
    at beginWork (react-dom.development.js:21626:16)
    at HTMLUnknownElement.callCallback2 (react-dom.development.js:4164:14)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:4213:16)
    at invokeGuardedCallback (react-dom.development.js:4277:31)
    at beginWork$1 (react-dom.development.js:27490:7)
    at performUnitOfWork (react-dom.development.js:26596:12)
    at workLoopSync (react-dom.development.js:26505:5)

HunterBarclay · 2024-07-15T17:54:22Z

@LucaHaverty Oops, I'll take care of it

LucaHaverty

Besides the slider things, I could not find any other issues, great work!

LucaHaverty · 2024-07-15T18:07:16Z

fission/src/ui/components/Slider.tsx

@@ -12,16 +12,15 @@ type SliderProps = {
    label?: string
    min: number
    max: number
-    defaultValue: number


Perhaps this is the cause of the slider issues? Maybe due to a merge?

@LucaHaverty could you look at that again and see if you can find errors with the fix
I didn't touch the ZoneConfigPanel because I don't want merge conflicts from your PR

Added changes to other files but ignored ZoneConfigPanel due to PR #1021 changing it

…tor-config

LucaHaverty

Everything worked well, fantastic work!

Dhruv-0-Arora · 2024-07-10T05:58:13Z

fission/src/systems/scene/SceneRenderer.ts

-                    if (isDragging) {
-                        return
-                    }
+                if (!event.value && !Array.from(this.transformControls.keys()).some(tc => tc.dragging)) {


That is true it would be more optimized

Dhruv-0-Arora · 2024-07-15T19:02:42Z

fission/src/ui/components/Slider.tsx

@@ -12,16 +12,15 @@ type SliderProps = {
    label?: string
    min: number
    max: number
-    defaultValue: number


@LucaHaverty could you look at that again and see if you can find errors with the fix
I didn't touch the ZoneConfigPanel because I don't want merge conflicts from your PR

fission/src/mirabuf/IntakeSensorSceneObject.ts

fission/src/mirabuf/MirabufSceneObject.ts

BrandonPacewic

@Dhruv-0-Arora Are you not the author of this PR? Or did @HunterBarclay take this one over?

Dhruv-0-Arora · 2024-07-15T22:42:41Z

@Dhruv-0-Arora Are you not the author of this PR? Or did @HunterBarclay take this one over?

Hunter is the owner for this one

a-crowell

Works great! Just removed an unused import.

BrandonPacewic

Want to make sure @Dhruv-0-Arora 's comments are looked at before merge.

could you do gpAssoc?.isGamePiece

Originally posted by @Dhruv-0-Arora in #1017 (comment)

@LucaHaverty could you look at that again and see if you can find errors with the fix
I didn't touch the ZoneConfigPanel because I don't want merge conflicts from your PR

Originally posted by @Dhruv-0-Arora in #1017 (comment)

That is true it would be more optimized

Originally posted by @Dhruv-0-Arora in #1017 (comment)

Outdated

Dhruv-0-Arora added 12 commits July 3, 2024 15:19

Adding configure pickup in panelui

98caf9f

Need to merge transform gizmo code to add a sphere in the scene for implementation.

Merge remote-tracking branch 'origin/dhruv/1733/mirabuf-gizmo' into d…

b8ccf13

…hruv/1728/intake-ejector-config

Merge branch 'dhruv/1733/mirabuf-gizmo' into dhruv/1728/intake-ejecto…

be8c4d0

…r-config

Merge remote-tracking branch 'origin/dhruv/1733/mirabuf-gizmo' into d…

6196bb5

…hruv/1728/intake-ejector-config

Added transform gizmo bug fixes and also cancel functionality

4d05972

Readded slider for sizing and configuration for the slider

2810af4

Merging dev

2f70b40

Merge branch 'dhruv/1733/mirabuf-gizmo' into dhruv/1728/intake-ejecto…

72949b5

…r-config

Quick fix

e7da8c3

Removing duplicate line of code after merge

Merge remote-tracking branch 'origin/barclah/1682/mouse-interaction' …

bcc4e87

…into dhruv/1728/intake-ejector-config

Merge branch 'dhruv/1733/mirabuf-gizmo' into dhruv/1728/intake-ejecto…

09faae5

…r-config

Added scaling functionality with slider

7ed6995

Dhruv-0-Arora requested review from HunterBarclay and a team as code owners July 9, 2024 00:32

Dhruv-0-Arora requested review from azaleacolburn and removed request for a team July 9, 2024 00:32

Dhruv-0-Arora marked this pull request as draft July 9, 2024 00:32

Dhruv-0-Arora self-assigned this Jul 9, 2024

Dhruv-0-Arora added 4 commits July 8, 2024 17:34

Raycasting work and basic implementation of pickup configuration

49b9e5e

Merge remote-tracking branch 'origin/dev' into dhruv/1728/intake-ejec…

518c7c5

…tor-config

Added storing data functionality

866936d

Added configuration for shot trajectory

39c1316

azaleacolburn added the physics Relating to either the underlying physics engine or the usage of it label Jul 9, 2024

azaleacolburn previously requested changes Jul 9, 2024

View reviewed changes

LucaHaverty mentioned this pull request Jul 9, 2024

Scoring Zones Configuration #1021

Merged

3 tasks

Dhruv-0-Arora and others added 5 commits July 9, 2024 22:43

Merge remote-tracking branch 'origin/barclah/1682/mouse-interaction' …

cdbf94c

…into dhruv/1728/intake-ejector-config

Merge remote-tracking branch 'origin/dhruv/1733/mirabuf-gizmo' into d…

d29f443

…hruv/1728/intake-ejector-config

Bug fix + ran prettier + fixed transform gizmo size from merge

85ed61a

Merge branch 'haverty/1692/preferences' into dhruv/1728/intake-ejecto…

8f5b1da

…r-config

Prevented select node from selecting a field or the ground

88b1ea3

need to fix bug of onCancel function not being run when another MainHUD panel being opened

Merge branch 'dev' into dhruv/1728/intake-ejector-config

3e3a437

HunterBarclay added 2 commits July 15, 2024 10:45

Renamed BodyAssociated to BodyAssociate, made requested changes.

7247694

Adding unit tests

f6495e7

LucaHaverty reviewed Jul 15, 2024

View reviewed changes

Dhruv-0-Arora added 3 commits July 15, 2024 11:51

Fixed poker slider error

764749e

Added changes to other files but ignored ZoneConfigPanel due to PR #1021 changing it

Merge remote-tracking branch 'origin/dev' into dhruv/1728/intake-ejec…

f75fc6b

…tor-config

Formatting

46c49fa

LucaHaverty approved these changes Jul 15, 2024

View reviewed changes

Fixing body associates

0fc72c8

HunterBarclay requested a review from azaleacolburn July 15, 2024 20:48

Dhruv-0-Arora commented Jul 15, 2024

View reviewed changes

BrandonPacewic reviewed Jul 15, 2024

View reviewed changes

BrandonPacewic assigned HunterBarclay Jul 15, 2024

BrandonPacewic removed the request for review from HunterBarclay July 15, 2024 22:43

Removed unused var eslint complaint

14e878d

a-crowell approved these changes Jul 15, 2024

View reviewed changes

BrandonPacewic requested changes Jul 15, 2024

View reviewed changes

made requested change

1b18b3f

HunterBarclay requested a review from BrandonPacewic July 15, 2024 23:54

BrandonPacewic approved these changes Jul 16, 2024

View reviewed changes

HunterBarclay merged commit 96185ad into dev Jul 16, 2024
12 checks passed

HunterBarclay deleted the dhruv/1728/intake-ejector-config branch July 16, 2024 00:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Intake and Ejector Configurator #1017

Intake and Ejector Configurator #1017

Dhruv-0-Arora commented Jul 9, 2024 •

edited by HunterBarclay

Loading

azaleacolburn Jul 9, 2024

Dhruv-0-Arora Jul 10, 2024

azaleacolburn Jul 9, 2024

Dhruv-0-Arora Jul 10, 2024

azaleacolburn Jul 9, 2024

Dhruv-0-Arora Jul 10, 2024

HunterBarclay commented Jul 15, 2024

azaleacolburn commented Jul 15, 2024

HunterBarclay commented Jul 15, 2024 •

edited

Loading

HunterBarclay commented Jul 15, 2024

LucaHaverty commented Jul 15, 2024 •

edited

Loading

HunterBarclay commented Jul 15, 2024 •

edited

Loading

LucaHaverty left a comment

LucaHaverty Jul 15, 2024

Dhruv-0-Arora Jul 15, 2024

LucaHaverty left a comment

Dhruv-0-Arora Jul 10, 2024

Dhruv-0-Arora Jul 15, 2024

BrandonPacewic left a comment

Dhruv-0-Arora commented Jul 15, 2024

a-crowell left a comment

BrandonPacewic left a comment

Intake and Ejector Configurator #1017

Intake and Ejector Configurator #1017

Conversation

Dhruv-0-Arora commented Jul 9, 2024 • edited by HunterBarclay Loading

Description

Features

Robot with configured pickup zone

Robot holding a Game Piece

Intake Configuration

Ejector Configuration

Temporary Components

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HunterBarclay commented Jul 15, 2024

azaleacolburn commented Jul 15, 2024

HunterBarclay commented Jul 15, 2024 • edited Loading

HunterBarclay commented Jul 15, 2024

LucaHaverty commented Jul 15, 2024 • edited Loading

HunterBarclay commented Jul 15, 2024 • edited Loading

LucaHaverty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LucaHaverty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BrandonPacewic left a comment

Choose a reason for hiding this comment

Dhruv-0-Arora commented Jul 15, 2024

a-crowell left a comment

Choose a reason for hiding this comment

BrandonPacewic left a comment

Choose a reason for hiding this comment

Dhruv-0-Arora commented Jul 9, 2024 •

edited by HunterBarclay

Loading

HunterBarclay commented Jul 15, 2024 •

edited

Loading

LucaHaverty commented Jul 15, 2024 •

edited

Loading

HunterBarclay commented Jul 15, 2024 •

edited

Loading