-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAN Support #1050
CAN Support #1050
Conversation
…Autodesk/synthesis into colbura/1747/can-motor-support
…ura/1747/can-motor-support
…ura/1747/can-motor-support
…ura/1747/can-motor-support
…ura/1747/can-motor-support
…ura/1747/can-motor-support
…ura/1747/can-motor-support
Co-authored-by: Brandon Pacewic <92102436+BrandonPacewic@users.noreply.github.com>
…utodesk/synthesis into colbura/1747/can-motor-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HunterBarclay Did you follow the following instructions from #1043?
|
@azaleacolburn Why aren't the vendor deps just already added? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so cool! And motors are connecting great! Encoder isn't connecting for me though, so auto doesn't stop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super impressive! If I knew how to get a device from id, I'd let you know, but alas I am without that knowledge and the code is working great. So excited for code sim!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super awesome!
Description
Send, receive, and use CAN device data between a robot project and fission.
Objectives
Testing Done
For testing:
./gradlew build
and./gradlew publishToMavenLocal
../gradlew build
and./gradlew simulateJava
.We need to have a discussion about how we want device mapping to work, right now every motor in a group's output is averaged and applied to each driver. We need to make it easier to do one to one mappings between motors and drivers, because right now, clicking through the whole menu ~10 times to make an output group for each motor is ridiculous.
Note
Pulled from #1077 for it's encoder framework, so I think just turning that PR into a gyro / joystick PR is the way to go.
Note
CANMotor inputs (eg. supplyCurrent) have been ignored, since they're not simulated in fission.
This PR is a combination of JIRA Issues 1747, 1748, and 1749 for a total of 18 story points.