Update $company_tagline check for PHP8+

[anaemnesis]

Fixes # #2424

Changes proposed in this Pull Request

As of PHP8, passing null to strlen() is deprecated. The $company_tagline var is assigned to the output of the get_the_company_tagline function, which returns null under certain conditions.

With this change, we're checking that $company_tagline exists: continue if it does, but if it's null or doesn't exist, return early.

Testing instructions

• Check out branch
• Create a new job listing with a company tagline
• Ensure no tagline shows if one is not present, and a tagline shows if one is present

[aaronfc]

Hey! It is looking good!

I am not sure if "company_tagline" could be "0" (a string with just a 0). In that case this condition wouldn't behave the same.

(Check here if you are curious).

If that's something that we don't expect to happen I am ok with the fix. But if this could ever happen I would suggest doing a check like is_null($company_tagline) || 0 === strlen($company_tagline).

Or maybe even 0 === strlen($company_tagline ?? '').

What do you think?

[anaemnesis]

@aaronfc I checked for (string) 0 and couldn't replicate a use-case where it happened, but just in case, I'll go with

if ( is_null( $company_tagline ) || 0 === strlen($company_tagline) ) {
	return;
}

This way, we're checking for null or 0 specifically rather than existence.

Committed a0556d6