Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update $company_tagline check for PHP8+ #2430

Merged
merged 2 commits into from
May 30, 2023
Merged

Commits on May 25, 2023

  1. Update $company_tagline check for PHP8+

    As of PHP8, passing `null` to `strlen()` is deprecated. The `$company_tagline` var is assigned to the output of the `get_the_company_tagline` function, which returns `null` under certain conditions.
    
    With this change, we're checking that `$company_tagline` exists: continue if it does, but if it's `null` or doesn't exist, return early.
    anaemnesis committed May 25, 2023
    Configuration menu
    Copy the full SHA
    c67ed3d View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Check for null or 0 explicitly

    To be safe, let's check for `null` or `0` (string) explicitly.
    anaemnesis committed May 30, 2023
    Configuration menu
    Copy the full SHA
    a0556d6 View commit details
    Browse the repository at this point in the history