Add comment sorting support #1024
Conversation
|
I've deployed the changes to https://commentsort-ampconfdemo.pantheonsite.io/2018/02/06/are-you-there-lebron-its-me-lebron-a-superstars-ultimate-pep-talk/ (with re-generated spec not yet pushed to this branch). However, it doesn't seem to be working: https://youtu.be/1Zh7L9_uI6k |
* Add maps URL protocol. * Allow referrerpolicy in links. * Allow expand-single-section on amp-accordion. * Allow template attribute on amp-ad and amp-embed. * Add amp-beopinion component. * Add amp-bodymovin-animation component. * Allow lightbox attributes on amp-carousel, amp-img, amp-video, amp-youtube. * Add amp-document-recommendations component. * Allow amp-ima-video@autoplay. * Allow amp-list to have amp-bind [src]. * Add amp-live-list@sort. * Add amp-story components: amp-story-cta-layer, amp-story-auto-ads. * Add blacklist value regex to link@rel. * Add 'link rel=preload'. * Update regex for 'link rel=stylesheet for fonts'. * Add 'meta name=amp-to-amp-navigation'. * Add amp-subscriptions.
|
It seems to test you have to both enable |
westonruter
changed the title
westonruter
changed the title
|
@kienstra This is live now (and will be in validator shortly): ampproject/amphtml#5396 (comment) So it can be merged and tested, along with the change to the ampconf theme: xwp/ampnews#84 |
There was a problem hiding this comment.
Approved
Hi @westonruter,
This PR looks good, and it works well locally with the AMPConf theme PR #84.
Could you please merge this? I would, but I don't have permissions.
Depends on ampproject/amphtml#5396 which should be deployed to production in the next couple weeks (when experiment flag is disabled: ampproject/amphtml#13552). This is something that should be part of 0.7.
sort=ascendingtoamp-live-list(see Add sort=ascending to amp-live-list for comments when asc order xwp/ampnews#84).sort=ascendingattribute.AMP.toggleExperiment('amp-live-list-sorting')(to check if it is enabled, runAMP.isExperimentOn('amp-live-list-sorting'))