Skip to content
This repository was archived by the owner on Apr 25, 2019. It is now read-only.

Fix lint errors #237

Merged
merged 1 commit into from
Jun 24, 2016
Merged

Fix lint errors #237

merged 1 commit into from
Jun 24, 2016

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Jun 24, 2016

This pull request removes linting issues. I had to disabled no-vendor-prefix which is a shame. That's because I couldn't find an alternative way to achieve this rule without a vendor prefix, or a way to disable checking the line.

Testing instructions

  1. Run git checkout [branch] and start your server, or open a live branch
  2. Open the Home page in IE
  3. Check that search still looks ok

Reviews

  • Code

@Automattic/sdev-feed

@stephanethomas
Copy link
Contributor

The code looks good. It seems there is a pull request for sass-lint that will offer the option to disable a lint rule for a specific line. We may want to keep an eye on it since that would fix our issue nicely.

@scruffian
Copy link
Member Author

The code looks good. It seems there is a pull request for sass-lint that will offer the option to disable a lint rule for a specific line. We may want to keep an eye on it since that would fix our issue nicely.

I subscribed to it...

@scruffian scruffian merged commit c2c0e33 into master Jun 24, 2016
@scruffian scruffian deleted the fix/linting branch June 24, 2016 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants