Disable linters

[DanPurdy]

Ongoing work for disabling linters via source.

closes #70

Ongoing from the work of @donabrams in #402

Everyone feel free to contribute to this branch feature/disable-linters

[avinashci]

To start with the issue is in index.js file. In the sassLint.lintText method, following statements should be called after the ast is generated.
ruleToggles = getToggledRules(ast);
isEnabledFilter = isResultEnabled(ruleToggles);

The above lines should move inside the block that runs the rules.

if (ast.content && ast.content.length > 0) {
ruleToggles = getToggledRules(ast);
isEnabledFilter = isResultEnabled(ruleToggles);

I made the changes locally and the tests for rules are passing.

[DanPurdy]

Thanks @avinashci as mentioned there has been a lot of changes to sass-lint since this was last worked on including the block of code you highlighted the result you're seeing is just the result of the work being brought up to date with the current version and is unfortunately not finished..

Thanks for that catch though, feel free to open a PR into the disable linter branch to contribute that change. We'll be moving forward with updating this all very soon

[DanPurdy]

Please do not add comments in PR's unless they add something to the discussion. Issues can be used to request features and github's reactions can be used to show your support for things.

[saptar]

submitted a pull request #723 to incorporate changes for programatically enabling/disabling linting ; as a part of issue # 70.

[saptar]

Hi @DanPurdy ,
I have updated the PR #723 .
Thanks!
-Saptarshi

[coveralls]

Coverage decreased (-0.03%) to 97.237% when pulling c9a3b65 on feature/disable-linters into b2f8523 on develop.

[avinashci]

Looks like the merge issues are resolved and the changes have been integrated to the branch. Anymore help needed here?

[DanPurdy]

There are no tests for .sass syntax and I've not had time to go through it properly but I will.. Yeah the main thing holding it back at the moment is the sass tests

[saptar]

Hi @DanPurdy ,

I have created a PR #743 to add test cases for .sass syntax.

Thanks!

[goesbysteve]

My team mates and I would like to contribute to this. How best can we help? I realise we are a little late to the party;-)

[DanPurdy]

Hi @stevegibbings, Thanks for the offer any help provided would be appreciated (personally struggling to find time at moment!)

There's an issue in #743 that would need looking at in order to make sure the Sass syntax is working correctly. It looks like an issue with Sass and CRLF line endings.

Alternatively throwing a few more test cases at both syntaxes with a view to just releasing this functionality for scss in the meantime would be appreciated.

Basically any help or light that can be shed on this feature would be greatly appreciated.

[coveralls]

Coverage decreased (-0.04%) to 97.337% when pulling aaa452c on feature/disable-linters into 6f5a509 on develop.

[coveralls]

Coverage decreased (-0.1%) to 97.242% when pulling 535ba4d on feature/disable-linters into 6f5a509 on develop.

[DanPurdy]

Ah that's a bug with a previous version of our AST, shouldn't cause any issues now when we release the latest version of Sass-lint

[coveralls]

Coverage decreased (-0.04%) to 97.536% when pulling 000f3a0 on feature/disable-linters into 21a20eb on develop.

[coveralls]

Coverage decreased (-0.04%) to 97.54% when pulling b7a8832 on feature/disable-linters into d67549d on develop.

[coveralls]

Coverage decreased (-0.04%) to 97.54% when pulling b7a8832 on feature/disable-linters into d67549d on develop.

[coveralls]

Coverage decreased (-0.04%) to 97.54% when pulling 96bd89d on feature/disable-linters into d67549d on develop.

[coveralls]

Coverage decreased (-0.04%) to 97.54% when pulling d26b74b on feature/disable-linters into d67549d on develop.

[DanPurdy]

Will release with 1.10

[albell]

@DanPurdy Thank you! When should folks generally expect 1.10 to roll out?

[bgriffith]

@albell It's already out! 🎉