This repository was archived by the owner on Jun 20, 2023. It is now read-only.
switch to js based sass linter #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ignore: '**/third_party/**/*.scss' | ||
| options: | ||
| formatter: stylish | ||
| merge-default-rules: true |
There was a problem hiding this comment.
I got merge-default-rules: false when I pasted our scss lint config on https://sasstools.github.io/make-sass-lint-config/ .
There was a problem hiding this comment.
Yes, I adapted the output manually.
|
looks good & works. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2486, this replaces the ruby based scss-lint by node based sass-lint.
sass-lint does not yet support inline comments to disable specific rules (there is a pull request though: sasstools/sass-lint#677). I switched the affected rules to warning mode, meaning they will provide warning messages, but the process will still exit with exitcode 0.