Add changes to run isEnabledFilter after checking if the ast has content and is #723
Conversation
content. Resolves sasstools#70 DCO 1.1 Signed-off-by: Saptarshi Dutta <saptarshidutta31@yahoo.co.in>
|
Changes Unknown when pulling 5c13bf5 on saptar:feature/disable-linters into * on sasstools:feature/disable-linters*. |
|
I wanted this feature to be completed and integrated as i intend to use this feature in a upcoming project and hence i pitched in with this PR. I have read through the comments from Avinash and my solution is in line with his suggestions as well. |
| @@ -125,6 +125,9 @@ sassLint.lintText = function (file, options, configPath) { | |||
| } | |||
|
|
|||
| if (ast.content && ast.content.length > 0) { | |||
|
|
|||
| ruleToggles = getToggledRules(ast); | |||
There was a problem hiding this comment.
There's still an issue in this file as far as I can see though
ruleToggles etc are passing a blank object as ast here, these declarations should be empty as part of this PR.
|
@saptar thanks for the contribution if you could update with what I left above I can merge this into the disable linters branch for you. 👍 |
Resolves # 70 DCO 1.1 Signed-off-by: Saptarshi Dutta saptarshidutta31@yahoo.co.in
|
Changes Unknown when pulling 8795bc7 on saptar:feature/disable-linters into * on sasstools:feature/disable-linters*. |
|
Thanks |
This PR tries to resolve the issue with disable linter programatically as mentioned under feature request # 70.
As a part of the PR:
Added code block after conditional check to see if the ast has been created properly.
There are no associated warning or new test cases.
. Resolves #70
DCO 1.1 Signed-off-by: Saptarshi Dutta saptarshidutta31@yahoo.co.in