-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update entry points and target webpack configs #166
Conversation
Hey @unDemian these days my bandwidth to take more work is limited because I'm focused on finishing some tasks before going AFK in a couple of days. This PR does a lot of unrelated things and requires a lot of my brain power. In other situation, I wouldn't mind putting more reviewing hours so you don't have to, but I'm afraid I don't have them at the moment. I could offer some reviewing help to move this forward if this was divided into smaller PRs that make only one thing so we can land them separately as they're ready. |
No worries, I'll split it into smaller PRs. |
Summary
There are a couple of devex enhancements that are part of this PR
./src/api.js
file which acts as a single exporter of the Happychat client api and it is used for all targets' entry points.window
was added in order to have a more generic structure preparing for other targets like npmdist
was renamed tobrowser
because it does expose the happychat api to the window object (dist can be too generic especially as we add npm as a target also)development.local.json
similar to calypso and other hc products so that developers can easily override configuration fields without comiting them.Testing