Add local config files #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unDemian
changed the base branch from
update/dist-to-browser-target
to
update/add-dev-npm-commands
This was referenced Mar 27, 2018
Merged
lamosty
approved these changes
Mar 27, 2018
oandregal
reviewed
Apr 1, 2018
| @@ -8,6 +12,11 @@ import createConfig from 'src/lib/create-config'; | |||
| let configFile; | |||
| if ( 'development' === process.env.NODE_ENV ) { | |||
| configFile = require( 'src/config/development.json' ); | |||
| try { | |||
| // check if we have local git ignored config and use it to override the development.json | |||
| const localConfig = require( 'src/config/development.local.json' ); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #179
Summary
development.local.jsonconfig file that will be ignored by git but will override the values indevelopment.json.NODE_ENV's value local css or production (from widgets.wp.com) will be embedded in the js fileTesting
Create a duplicate of
src/config/development.jsonassrc/config/development.local.jsonchange the happychat url to point to your local happychat service. Runnpm startand check the network console to see that the client connects to your local happychat and also that local happychat.css file is loaded in the iframe instead of the production css.