Add css file to config #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2018
lamosty
approved these changes
Mar 27, 2018
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "css_url": "http://localhost:9000/happychat.css", | |||
There was a problem hiding this comment.
Maybe we could store the localhost:9000 url in a separate field as root? Though, it can't be reused within the same file..
There was a problem hiding this comment.
I don't think we need to worry about that right now.
There was a problem hiding this comment.
I like this approach better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #180
Summary
This PR moves the css url to the config files.
Testing
Run
npm startand local css style should be loaded properly.