Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Adds Data Attributes to Page/Post Images When Carousel Is Enabled #7771

Closed
pmciano opened this issue Sep 10, 2017 · 3 comments
Closed

Jetpack Adds Data Attributes to Page/Post Images When Carousel Is Enabled #7771

pmciano opened this issue Sep 10, 2017 · 3 comments
Labels
[Closed] Duplicate Duplicate of an existing issue. Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended

Comments

@pmciano
Copy link

pmciano commented Sep 10, 2017

If Carousel is enabled, Jetpack adds data attributes to page and post images, regardless of whether or not the images are part of a Carousel Gallery. I have replicated the issue using Twenty Seventeen 1.3 and Jetpack 5.3.

Data Attributes

As per @jeherve, this appears to be a bug.

3255391-t
@pmciano pmciano added [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] Low labels Sep 10, 2017
mitraval192 added a commit to mitraval192/jetpack that referenced this issue Sep 12, 2017
@mitraval192
add text transformations function and fixed Automattic#7771
aa96f99
@mitraval192 mitraval192 mentioned this issue Sep 12, 2017
Closed
@jeherve
Copy link
Member

jeherve commented Oct 10, 2017

Also reported here:
https://wordpress.org/support/topic/carousel-meta-information-removal/

@brbrr brbrr added the [Type] Bug When a feature is broken and / or not performing as intended label Jun 13, 2018
@stale
Copy link

stale bot commented Dec 10, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Dec 10, 2018
@samiff samiff mentioned this issue Jun 29, 2021
Closed
@jeherve
Copy link
Member

jeherve commented Jun 30, 2021

Closing as duplicate of #13428

@jeherve jeherve closed this as completed Jun 30, 2021
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Jun 30, 2021
@jeherve jeherve added the [Closed] Duplicate Duplicate of an existing issue. label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Closed] Duplicate Duplicate of an existing issue. Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jeherve @anomiex @brbrr @pmciano @matticbot