Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: add text transformations function and fixed #7771 #7774

Closed
wants to merge 1 commit into from
Closed

Carousel: add text transformations function and fixed #7771 #7774

wants to merge 1 commit into from

Conversation

mitraval192
Copy link

@mitraval192 mitraval192 commented Sep 12, 2017 •
edited by samiff
Loading

Edited to unlink: Fixes #7771

@mitraval192 mitraval192 requested a review from a team as a code owner September 12, 2017 10:12
@dereksmart dereksmart added [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Sep 20, 2017
@zinigor
Copy link
Member

zinigor commented Sep 27, 2017

Thank you for helping make Jetpack better!

Can you please add testing instructions? Make sure you specify the behaviour you wanted to improve. It will be best if you can add data that illustrates the problem.

@jeherve jeherve changed the title add text transformations function and fixed #7771 Carousel: add text transformations function and fixed #7771 Sep 28, 2017
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 28, 2017
@keoshi
Copy link
Contributor

keoshi commented Jun 5, 2018

Hi @mitraval192 — wanted to make sure you didn't miss @zinigor comment's above. Can you update the PR description with test instructions and some examples, please? Thank you.

@stale
Copy link

stale bot commented Sep 3, 2018

This PR has been marked as stale. This happened because:

  • It has been inactive in the past 3 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Sep 3, 2018
@kraftbj
Copy link
Contributor

kraftbj commented Feb 6, 2020

I'm going to close this due to lack of testing instructions and I'm not immediately sure how this would resolve 7771 glancing at the code.

@kraftbj kraftbj closed this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] Normal [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mitraval192 @zinigor @keoshi @kraftbj @jeherve @anomiex @dereksmart @matticbot