Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: Improve contrast for accessibility. #12112

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Conversation

beaulebens
Copy link
Member

Bumps accessibility rating for sharing buttons to WCAG AA & AAA Text
Props https://titan.as for submission via email.

Fixes #3227

Changes proposed in this Pull Request:

  • Darken the text/icons used in sharing buttons to #545454 to improve accessibility.

Testing instructions:

  • Enable Sharing buttons and add some to a post via Settings> Sharing
  • Make sure you're using "Icon + text" or "Text only" as the button style option
  • View a post and observe sharing buttons.

Before:
Screen Shot 2019-04-22 at 1 38 23 PM

After:
Screen Shot 2019-04-22 at 1 30 49 PM

Proposed changelog entry for your changes:

  • Improve accessibility of sharing buttons by increasing contrast ratio. Props https://titan.as

Bumps accessibility rating for sharing buttons to WCAG AA & AAA Text
Props https://titan.as for submission via email.
@beaulebens beaulebens added [Feature] Sharing Post sharing, sharing buttons [Focus] Accessibility Improving usability for all users (a11y) labels Apr 22, 2019
@beaulebens beaulebens requested a review from a team April 22, 2019 19:39
@beaulebens beaulebens self-assigned this Apr 22, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello beaulebens! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D27241-code before merging this PR. Thank you!

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 5be0577

@beaulebens beaulebens added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! labels Apr 22, 2019
Copy link
Contributor

@eliorivero eliorivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑
Code is good, needs design review and it can be merged.

@eliorivero eliorivero removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Apr 22, 2019
@MichaelArestad
Copy link
Contributor

Looks great!

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Design Review Design has been added. Needs a review! labels Apr 23, 2019
@jeherve jeherve merged commit 8d9bd71 into master Apr 23, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 23, 2019
@jeherve jeherve added this to the 7.3 milestone Apr 23, 2019
@jeherve jeherve deleted the fix/sharing-accessibility branch April 23, 2019 19:50
kraftbj added a commit that referenced this pull request Apr 26, 2019
kraftbj added a commit that referenced this pull request Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Post sharing, sharing buttons [Focus] Accessibility Improving usability for all users (a11y) Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing: color contrast ratio accessibility issue with text button style
7 participants