Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed color contrast according to WCAG AA #14084

Merged
merged 1 commit into from
Nov 25, 2019
Merged

fixed color contrast according to WCAG AA #14084

merged 1 commit into from
Nov 25, 2019

Conversation

kospl
Copy link
Contributor

@kospl kospl commented Nov 21, 2019 •
edited by jeherve
Loading

Fixes #12866

Changes proposed in this Pull Request:

  • accessibility fix for social media buttons color contrast

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • fix for existing social media buttons module sharedaddy

Testing instructions:

  • Open Chrome browser
  • Install aXe Web accessibility testing extension
  • Go to page with sharedaddy social media buttons
  • Open developer tools, go to aXe tab, click Analyze
    image
  • With PR changes applied, there should be no "Elements must have sufficient color contrast" issue in aXe results.

Proposed changelog entry for your changes:

  • accessibility fix for social media buttons color contrast

@kospl
fixed color contrast according to WCAG AA
269d424 
fixes color contrast issue from #12866
@kospl kospl requested a review from a team November 21, 2019 08:22
@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 269d424

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Accessibility Improving usability for all users (a11y) [Feature] Sharing Post sharing, sharing buttons labels Nov 21, 2019
@jeherve jeherve added this to the 8.0 milestone Nov 21, 2019
@kospl kospl mentioned this pull request Nov 21, 2019
Open
jeherve
jeherve approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you for the contribution.

@jeherve jeherve removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 25, 2019
@jeherve
Copy link
Member

jeherve commented Nov 25, 2019

Noting that this PR follows up on the contrast changes already made in #12112.

@jeherve jeherve merged commit 5775824 into Automattic:master Nov 25, 2019
@jeherve
Copy link
Member

jeherve commented Nov 25, 2019

Internal reference: D35885-code

jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
Changelog: add #14084
01f1288
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
8.0 Release: running changelog (#13964)
807ab89 
* 8.0 Release: running changelog

* Changelog: add #13921

* Changelog: add #13980

* Changelog: add #13905

* Changelog: add #13971

* Changelog: add #13984

* Changelog: add #14009

* Changelog: add #13620

* Remove things that will ship in 7.9.1

* Changelog: add 7.9.1 release (#14044)

* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066

* Update changelog for 7.9.1

* Changelog: add #13405

* Changelog: add #13841

* Changelog: add #13924

* Changelog: add #13986

* Changelog: add #14010, #14028, #14053, #14055.

* Changelog: add #14054

* Changelog: add #14031

* Changelog: add #14039

* Changelog: add #14050

* Changelog: add #14070

* Changelog: add #14082

* Changelog: add #14084

* Changelog: add #14111

* Changelog: add #13961

* Changelog: add #14047

* Changelog: add #14091

* Changelog: add #14108

* Changelog: add #14121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees
No one assigned
Labels
[Feature] Sharing Post sharing, sharing buttons [Focus] Accessibility Improving usability for all users (a11y) [Status] Needs Design Review Design has been added. Needs a review! Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

Jetpack Sharing & Likes button request to apply WCAG 2.1 style and functionality standards
4 participants
@kospl @jetpackbot @jeherve @matticbot