Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the contact form reusable #13924

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Make the contact form reusable #13924

merged 1 commit into from
Nov 19, 2019

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Nov 1, 2019 •
edited
Loading

When Contact Forms were originally created we disabled the ability to make them reusable because the preview was broken (https://github.com/Automattic/wp-calypso/issues/).

Now that the preview is working we should re-enable this.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • An improvement to an existing feature

Testing instructions:

  • Create a new post and add a contact form block
  • Make the contact form reusable
  • Look at the reusable block in the block picker
  • Check that the preview looks correct

contact form

As you can see at the end of the video the editor throws an error. I can't reproduce this, so I assume its unrelated.

Proposed changelog entry for your changes:

  • Make contact form blocks reusable.

@scruffian scruffian added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Nov 1, 2019
@scruffian scruffian requested a review from a team November 1, 2019 10:43
@scruffian scruffian self-assigned this Nov 1, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D34874-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Nov 1, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 5d94adc

simison
simison reviewed Nov 1, 2019
View reviewed changes
extensions/blocks/contact-form/index.js Outdated
@@ -33,7 +33,7 @@ export const settings = {
],
category: 'jetpack',
supports: {
reusable: false,
reusable: true,
Copy link
Member

@simison simison Nov 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just remove the whole line since reusable defaults to true.

https://developer.wordpress.org/block-editor/developers/block-api/block-registration/#supports-optional

@matticbot
Copy link
Contributor

scruffian, Your synced wpcom patch D34874-code has been updated.

@jeherve jeherve added [Feature] Contact Form [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Nov 4, 2019
@jeherve jeherve added this to the 8.0 milestone Nov 4, 2019
@jeherve jeherve force-pushed the update/contact-form-reusable branch from 4b30693 to 5d94adc Compare November 4, 2019 14:39
@jeherve
Copy link
Member

jeherve commented Nov 4, 2019

Rebasing to try to fix tests.

@matticbot
Copy link
Contributor

scruffian, Your synced wpcom patch D34874-code has been updated.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 19, 2019
jeherve
jeherve approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well in my tests. Merging.

@jeherve jeherve merged commit 62d6386 into master Nov 19, 2019
@jeherve jeherve deleted the update/contact-form-reusable branch November 19, 2019 15:39
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 19, 2019
@jeherve jeherve mentioned this pull request Nov 21, 2019
Closed
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
Changelog: add #13924
d803f3c
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
8.0 Release: running changelog (#13964)
807ab89 
* 8.0 Release: running changelog

* Changelog: add #13921

* Changelog: add #13980

* Changelog: add #13905

* Changelog: add #13971

* Changelog: add #13984

* Changelog: add #14009

* Changelog: add #13620

* Remove things that will ship in 7.9.1

* Changelog: add 7.9.1 release (#14044)

* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066

* Update changelog for 7.9.1

* Changelog: add #13405

* Changelog: add #13841

* Changelog: add #13924

* Changelog: add #13986

* Changelog: add #14010, #14028, #14053, #14055.

* Changelog: add #14054

* Changelog: add #14031

* Changelog: add #14039

* Changelog: add #14050

* Changelog: add #14070

* Changelog: add #14082

* Changelog: add #14084

* Changelog: add #14111

* Changelog: add #13961

* Changelog: add #14047

* Changelog: add #14091

* Changelog: add #14108

* Changelog: add #14121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison left review comments

@jeherve jeherve jeherve approved these changes

Assignees

@scruffian scruffian

Labels
[Feature] Contact Form [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@scruffian @matticbot @jetpackbot @jeherve @simison