Payments Block: Remove upgrade nudges when used in Premium Content block

[apeatling]

Changes proposed in this Pull Request:

Remove all native upgrade nudges inside the Payments block when used within the Premium Content block. This stops the duplication of nudges when used together. This also helps us when using these blocks in patterns so the canvas is cleaner.

Partially fixes Automattic/wp-calypso#46923

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• First apply this PR and sync to your sandbox to provide context: Premium Content: Provide block context to the payments button wp-calypso#47245
• Apply this Jetpack PR
• Sync to your dotcom sandbox
• Sandbox a free WordPress.com site
• Insert a premium content block
• Confirm that you can edit the block on a free plan, and the "Subscribe" button is visible (not a placeholder or nudge instead).

Proposed changelog entry for your changes:

• None needed.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello apeatling! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D52237-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[jetpackbot]

	Warnings
⚠️	pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against aefc05d

[apeatling]

I need to check these options are still available when using this within the premium content block, now that the placeholder is hidden there

[glendaviesnz]

I get some weird layout caused by the payments disclaimer block (seedlet theme):

[apeatling]

I get some weird layout caused by the payments disclaimer block (seedlet theme):

This disclaimer is being moved to the sidebar in #17696 so that should clean up this visual issue. 👍

[glendaviesnz]

This seems to work for me. With both diffs applied to sandbox I just see one upgrade nudge at the top, and content and subscribe buttons are visible:

I also see this same nudge in centre of block if the payment parent block is selected - is that correct?

[apeatling]

I also see this same nudge in centre of block if the payment parent block is selected - is that correct?

Yes this won't hide the global upgrade nudge UI, just any placeholders local to the block that ask you to upgrade.

[glendaviesnz]

LGTM

[jeherve]

Insert a premium content block

This must be a stupid question, but how do I go about doing that? I can't seem to see a Premium Content block on my WordPress.com simple sites.

---

Maybe this would be an opportunity to move away from the custom upgrade nudge of the Payments block, and switch to using the standard upgrade nudges like all the other blocks have? This is documented in #14893. That may allow us to fix that issue for all parent/child blocks at once, directly in the upgrade banner logic in extensions/extended-blocks/paid-blocks/.
What do you think?

[apeatling]

This must be a stupid question, but how do I go about doing that? I can't seem to see a Premium Content block on my WordPress.com simple sites.

@jeherve I believe there are issues with the way Premium Content manages this, it's not in Jetpack so it has duplicated and forked a lot of the nudge and restriction code. It shows on some of my free sites, but not all. What we plan to do is move this block into Jetpack in the coming weeks so we can remove all the duplicated code and unify it with the Jetpack implementation.

Okay to move forward with merging this and addressing that as a followup?

[ockham]

What we plan to do is move this block into Jetpack in the coming weeks so we can remove all the duplicated code and unify it with the Jetpack implementation.

@apeatling This is great news, thanks a lot for taking this on! 🎉 One request, could y'all maybe add an issue to your team's board to add some basic e2e test coverage for that block in order to guard against regressions like the one we're hoping to fix with Automattic/wp-calypso#47467? There's some precedent of e2e tests for paid blocks in JP already, and e2e tests are run against the latest GB plugin version, so the basic infrastructure should be in place already.

[apeatling]

@jeherve Good to merge this one?

[jeherve]

All good after a rebase to address unrelated test failures.

[apeatling]

@jeherve Thanks, rebased. just need another approval here to merge.

[jeherve]

r219427-wpcom