Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Premium Content: Provide block context to the payments button #47245

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Premium Content: Provide block context to the payments button #47245

merged 1 commit into from
Nov 9, 2020

Conversation

apeatling
Copy link
Member

Changes proposed in this Pull Request

  • Provide a context to allow the payments button to know when it's inside the premium content block.

Testing instructions

Should be tested using instructions from Automattic/jetpack#17702

@apeatling apeatling added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Premium Content Controlling specific content for paying site visitors. labels Nov 9, 2020
@apeatling apeatling requested a review from a team November 9, 2020 18:52
@apeatling apeatling self-assigned this Nov 9, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/premium-content-block-context

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 9, 2020
@apeatling apeatling mentioned this pull request Nov 9, 2020
Merged
@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D52469-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

glendaviesnz
glendaviesnz approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeatling apeatling merged commit dd9e291 into master Nov 9, 2020
@apeatling apeatling deleted the add/premium-content-block-context branch November 9, 2020 20:22
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 9, 2020
@p-jackson p-jackson mentioned this pull request Nov 15, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glendaviesnz glendaviesnz glendaviesnz approved these changes

Assignees

@apeatling apeatling

Labels
Premium Content Controlling specific content for paying site visitors. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeatling @matticbot @glendaviesnz