Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock file maintenance #31769

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Lock file maintenance #31769

merged 3 commits into from
Jul 10, 2023

Conversation

matticbot
Copy link
Contributor

@matticbot matticbot commented Jul 10, 2023 •
edited
Loading

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.

Configuration

📅 Schedule: Branch creation - "before 3:00 am on Monday on the 7th through 13th day of the month" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@matticbot matticbot added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Jul 10, 2023
@github-actions github-actions bot added [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VaultPress [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. labels Jul 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the renovate/lock-file-maintenance branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack renovate/lock-file-maintenance

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin renovate/lock-file-maintenance

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

zinigor
zinigor reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node downgrades look weird, but everything else seems like minor dependency bumps.

pnpm-lock.yaml Outdated
dev: true

/@types/glob@8.1.0:
resolution: {integrity: sha512-IO+MJPVhoqz+28h1qLAcBEH2+xHMK6MTyHJc7MTnnYb6wsoLR29POVGJ7LycmVXIqyy/4/2ShP5sUwTXuOwb/w==}
dependencies:
'@types/minimatch': 5.1.2
'@types/node': 20.3.1
'@types/node': 16.18.38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird node downgrade.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly a node downgrade, just a downgrade on the package that tells typescript about types for node builtins.

I'm guessing it decided to downgrade because the only dep on this comes via @storybook/core-common → glob-promise → @types/glob, and @storybook/core-common depends on @types/node ^16.0.0, so the deduplication logic decided it may as well have just one version of @types/node in the tree rather than two. But why it decided to do that now rather than last month I have no idea.

pnpm-lock.yaml Outdated
@@ -9906,16 +9969,16 @@ packages:
/@types/node-fetch@2.6.4:
resolution: {integrity: sha512-1ZX9fcN4Rvkvgv4E6PAY5WXUFWFcRWxZa3EW83UjycOB9ljJCedb2CupIP4RZMEwF/M3eTcCihbBRgwtGbg5Rg==}
dependencies:
'@types/node': 20.3.1
'@types/node': 16.18.38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another weird node downgrade.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the above.

@anomiex
Copy link
Contributor

anomiex commented Jul 10, 2023

Artifact update problem seems to be an issue with @wordpress/block-editor, filed upstream as WordPress/gutenberg#52474

@anomiex
Copy link
Contributor

anomiex commented Jul 10, 2023

Store "core/preferences" is already registered.

Whee. Called it last month: #31308 (comment)

@matticbot matticbot force-pushed the renovate/lock-file-maintenance branch from 57cb30e to 577003c Compare July 10, 2023 17:20
anomiex added 2 commits July 10, 2023 13:43
@anomiex
Ignore lint
85e3fa7
@anomiex
Fix broken type declaration
aee3274 
Apparently the return types of `setTimeout()` and `setInterval()` depend
on the environment, in browsers they're numbers while in node they're
`Timeout` and `Timer`. I have no idea why, but some update here
(assocated with the "expect" package?) makes tsc suddenly start
complaining about this.

Some quick searching suggests that the way to do this is to either
remove the type declarations or do like `ReturnType< typeof setTimeout >`
to let typescript figure it out. I went with the latter, since
someone felt that declaring the type here in the first place was a good
idea.

But to make *that* work, we also need to rename the `ReturnType` type
variable to something else so it doesn't mask TypeScript's built-in
`ReturnType<>` utility type. Whee.
@github-actions github-actions bot added [JS Package] Boost Score Api Admin Page React-powered dashboard under the Jetpack menu RNA labels Jul 10, 2023
@anomiex anomiex enabled auto-merge (squash) July 10, 2023 19:04
anomiex
anomiex approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy, and a JN site seems to work too

@anomiex anomiex merged commit 62a6060 into trunk Jul 10, 2023
@anomiex anomiex deleted the renovate/lock-file-maintenance branch July 10, 2023 19:14
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinigor zinigor zinigor left review comments

@anomiex anomiex anomiex approved these changes

Assignees
No one assigned
Labels
Admin Page React-powered dashboard under the Jetpack menu [JS Package] Boost Score Api [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VaultPress [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. RNA [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matticbot @anomiex @zinigor @renovate-bot