Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Update share status modal to use Dataviews component #39230

Merged

Conversation

manzoorwanijk
Copy link
Member

Share status modal on mobile looks messed up. See #39051 (comment)

Proposed changes:

  • Make use of DataViews component to render the list of shares
  • Thus, fix the mobile view

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Enable the share status feature - define( 'JETPACK_SOCIAL_HAS_SHARE_STATUS', true );
  • Goto the post editor for a post which has some shares or reshare posts to create a few entries (at least 10)
  • Click on "View share history" in the publicize panel
  • Confirm that the modal and data renders correctly
  • Confirm that the modal content is scrollable when the data is more than what can be displayed in the modal at once
  • Confirm that the mobile view isn't squeezed and is rather horizontally scrollable
BEFORE AFTER
Destop view
Screenshot 2024-09-04 at 4 26 45 PM Screenshot 2024-09-04 at 4 27 11 PM
Mobile view
Screenshot 2024-09-04 at 4 35 43 PM Screenshot 2024-09-04 at 4 35 08 PM

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-share-status-modal-to-use-dataviews branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social-share-status-modal-to-use-dataviews
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/social-share-status-modal-to-use-dataviews
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

},
{
id: 'timestamp',
label: __( 'Time', 'jetpack' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to call this Shared at or something similar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the continuation of the sentence doesn't read nice "Shared at 2 minutes ago", where as, "Time" can be read as its own clause.

Copy link
Contributor

@gmjuhasz gmjuhasz Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, time feels too vague, also I looked up on the designs it's 'Published at' on the admin page, maybe that's where I got the idea from :D I think Shared at still makes more sense than published at. Either way we should use the same term here and there in the future, even if that's time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what about the case of failure? We can't say "Shared at".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a point we have to make on the admin page designs too, but let's leave time now then

@manzoorwanijk
Copy link
Member Author

Build failure being discussed at p1725456184868289-slack-C05Q5HSS013

Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot better thanks for the refactor!

Just a minor comment, the View ExternalLink changed to black from the previous color, can we retain that?

@manzoorwanijk
Copy link
Member Author

Just a minor comment, the View ExternalLink changed to black from the previous color, can we retain that?

Fixed. Thanks

image

@manzoorwanijk manzoorwanijk merged commit 781e6cc into trunk Sep 6, 2024
73 checks passed
@manzoorwanijk manzoorwanijk deleted the update/social-share-status-modal-to-use-dataviews branch September 6, 2024 09:14
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
* Add @wordpress/dataviews as a dependency

* Create and use the dataview component

* Do some makeup

* Render and clean up

* Add changelog

* Copy paste clean up from previous PR

* Pass data from parent to avoid duplication

* Use only the styles from dataviews for now

* Restore link styles

* Add a comment about the color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants