-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social | Fix dataviews styles imported in share status being added globally #39991
Social | Fix dataviews styles imported in share status being added globally #39991
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Social plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well. I can't replicate the problem on Simple sites, but I can on a Jetpack site, and this fixes it.
I think this does highlight the need for being able to use the DataViews package itself, so these conflicts don't happen and we're shipping one copy of the code.
After #39230, we import dataviews styles for share status reporting in Social UIs, which results in dataviews styles being applied globally and if the dataviews styles are being updated which are immediately reflected if you use Gutenberg plugin, there will be styling conflicts.
This PR fixes that issue by scoping the import to our component that we need dataviews styling for.
Fixes #39981
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: