-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix where if a user isn't logged into wpcom, go to blank screen #8951
Conversation
5e3ede3
to
90ffdb5
Compare
Failing tests look unrelated to this PR |
fixes #8953 |
@withinboredom could you get someone from Growth to approve this one so we can get it cherry-picked to the release branch? |
This works and tests as expected, and avoids the blank screen in Calypso in a logged-out state. Both logged-in and -out flows need improving on the Calypso side, but that's fine. This keeps us in control and we can iterate there without needing to ship a Jetpack release. |
@oskosk is there some reason this hasn't been merged into the release yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@withinboredom . not other than I've been intermitently offline during the meetup I'm attending during this week. I'm doing it now |
Cherry-picked to |
When viewing the plans page, it is possible to be logged out of wpcom, this makes sure they go to the right flow depending on whether they're logged in or not by using the jetpack redirector.
Due to Automattic/wp-calypso#22857, we need to control the final destination of these links without requiring a jetpack release.
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes: