Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: Navigating to checkout for a specific product/site does not prompt customers to log in. #22857

Closed
bubel opened this issue Feb 27, 2018 · 0 comments · Fixed by #22993
Closed

Store: Navigating to checkout for a specific product/site does not prompt customers to log in. #22857

bubel opened this issue Feb 27, 2018 · 0 comments · Fixed by #22993
Assignees
@johnHackworth @seear
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. FixTheFlows [Pri] High Address as soon as possible after BLOCKER issues Store [Type] Bug When a feature is broken and / or not performing as intended

Comments

@bubel
Copy link
Contributor

bubel commented Feb 27, 2018

Steps to reproduce

  1. Starting at URL: https://wordpress.com/checkout/[YOUR-SITE-HERE/personal (You need to be logged out!)
  2. Receive a blank white screen with no feedback or messaging. Only the blue header appears.

What I expected

To be taken directly to the log-in form. Regardless of whether or not the customer/account can access that checkout URL (maybe it's not their site, for example), a log-in should be prompted immediately and the access decision handled afterward.

What happened instead

I did not receive any sort of message or log-in form. Just a blank page.

Browser / OS version

Firefox 58.0.2 / Mac Sierra 10.12.6

Context / Source

I stumbled upon this while testing logged-out upgrade flows from wp-admin for Jetpack.
@bubel bubel added [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. Store labels Feb 27, 2018
@beaulebens beaulebens added [Pri] High Address as soon as possible after BLOCKER issues FixTheFlows labels Feb 27, 2018
@withinboredom withinboredom mentioned this issue Feb 28, 2018
Merged
@designsimply designsimply added the [Type] Bug When a feature is broken and / or not performing as intended label Feb 28, 2018
@seear seear self-assigned this Mar 5, 2018
@seear seear mentioned this issue Mar 5, 2018
Merged
@rachelmcr rachelmcr mentioned this issue Mar 6, 2018
Closed
@rachelmcr rachelmcr mentioned this issue Apr 3, 2018
Closed
seear added a commit that referenced this issue Apr 3, 2018
@seear
Enable the /checkout/:domain/:product route for logged-out users (#22993
c91ce4f 
)

Fixes #22857

Currently, logged-out users arriving at wordpress.com/checkout/:domain/:product see a blank screen. This PR will show a login-form instead.

Adds a common middleware for diverting to Calypso /log-in form, before redirecting to the original requested route, meaning customers must log in before completing the purchase.

All other checkout routes remain logged-in only for now.

NOTE: This is a temporary solution for #22857 in lieu of a general fix in #23785.
stephanethomas added a commit that referenced this issue Apr 17, 2018
@stephanethomas
Google My Business: Redirect logged-out users to Login page
6ab0203 
This is a temporary solution for #22857 in lieu of a more general fix #23785.
stephanethomas added a commit that referenced this issue Apr 17, 2018
@stephanethomas
Google My Business: Redirect logged-out users to Login page
f5556ea 
This is a temporary solution for #22857 in lieu of a more general fix #23785.
taggon added a commit that referenced this issue May 4, 2018
@taggon
Checkout: redirect logged-out users to login page
9f0b208 
When logged-out, a blank screen is displayed on the all checkout pages but `/checkout/:domain/:product?`.
This trouble is caused by #22993 which fixed a bug filed in #22857 (see #23785 for the general problem).
For example, renewal email was also affected by this bug (see p9jf6J-rI-p2).

This PR fixes an empty page displayed to logged-out users when they try
to access any `/checkout` pages.
@taggon taggon mentioned this issue May 4, 2018
Merged
taggon added a commit that referenced this issue May 8, 2018
@taggon
Checkout: redirect logged-out users to login page (#24687)
c4ce061 
When logged-out, a blank screen is displayed on the all checkout pages but `/checkout/:domain/:product?`.
This trouble is caused by #22993 which fixed a bug filed in #22857 (see #23785 for the general problem).
For example, renewal email was also affected by this bug (see p9jf6J-rI-p2).

This PR fixes an empty page displayed to logged-out users when they try
to access any `/checkout` pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnHackworth johnHackworth

@seear seear

Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. FixTheFlows [Pri] High Address as soon as possible after BLOCKER issues Store [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable the /checkout/:domain/:product route for logged-out users Automattic/wp-calypso
5 participants
@beaulebens @bubel @designsimply @johnHackworth @seear