Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit change to module-headings.php #8981

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Commit change to module-headings.php #8981

merged 1 commit into from
Mar 6, 2018

Conversation

jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Mar 5, 2018

Minor Problem

Upon running npm run build from the master branch, the modules/module-headings.php file keeps showing up as a changed file, even though I didn't change anything in this file.

Reason

The Jumpstart description was removed a few days ago in #8938 but the built file was not committed with it at that time.

Solution

I ran npm run build to generate the new modules/module-headings.php file.

@jaswrks
Commit change to module-headings.php
aa1070f 
The Jumpstart description was removed a few days ago
in #8938 but the built file was not commited, so
this keeps showing up as a changed file whenever you
run `npm run build` locally.
@jaswrks jaswrks requested a review from a team as a code owner March 5, 2018 19:13
@jaswrks jaswrks requested a review from withinboredom March 5, 2018 19:13
@jaswrks jaswrks added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Mar 5, 2018
withinboredom
withinboredom approved these changes Mar 5, 2018
View reviewed changes
Copy link
Contributor

@withinboredom withinboredom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge as soon as it passes

@withinboredom withinboredom added [Status] Ready to Merge Go ahead, you can push that green button! [Type] Janitorial [Pri] Normal and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 5, 2018
@withinboredom withinboredom merged commit 4fa236a into master Mar 6, 2018
@withinboredom withinboredom deleted the fix/module-headings.php branch March 6, 2018 03:19
@Viper007Bond
Copy link
Contributor

I wondered why that file kept showing up as modified! I was thinking git was somehow broken, heh.

@jaswrks jaswrks mentioned this pull request Mar 7, 2018
Merged
@oskosk oskosk added this to the 6.0 milestone Mar 9, 2018
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@withinboredom withinboredom withinboredom approved these changes

Assignees
No one assigned
Labels
[Pri] Normal [Type] Janitorial
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jaswrks @Viper007Bond @withinboredom @kraftbj @oskosk @matticbot