Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should UUID be a valid RefType? #15101

Closed
2 tasks done
hasezoey opened this issue Dec 16, 2024 · 1 comment · Fixed by #15115
Closed
2 tasks done

Should UUID be a valid RefType? #15101

hasezoey opened this issue Dec 16, 2024 · 1 comment · Fixed by #15115
Labels
typescript Types or Types-test related issue / Pull Request
Milestone

Comments

@hasezoey
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

I have noticed that UUID is not part of RefType and have wondered if it should be valid (as Buffer is).

mongoose/types/index.d.ts

Lines 565 to 575 in b7b257e

export type RefType =
| number
| string
| Buffer
| undefined
| Types.ObjectId
| Types.Buffer
| typeof Schema.Types.Number
| typeof Schema.Types.String
| typeof Schema.Types.Buffer
| typeof Schema.Types.ObjectId;

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Dec 16, 2024
@vkarpov15
Copy link
Collaborator

It should be, I'll test this out.

@vkarpov15 vkarpov15 added this to the 8.9.2 milestone Dec 17, 2024
vkarpov15 added a commit that referenced this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants