Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: add UUID to RefType #15115

Merged
merged 1 commit into from
Dec 18, 2024
Merged

types: add UUID to RefType #15115

merged 1 commit into from
Dec 18, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #15101

Summary

Mongoose does support using ref on UUID paths, so we should also support it in the RefType and PopulatedDoc<> helpers.

Examples

@vkarpov15 vkarpov15 added this to the 8.9.2 milestone Dec 17, 2024
@vkarpov15 vkarpov15 requested a review from hasezoey December 17, 2024 21:10
hasezoey
hasezoey approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Dec 18, 2024
@vkarpov15 vkarpov15 merged commit e436f6a into master Dec 18, 2024
7 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-15101 branch December 18, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
8.9.2
Development

Successfully merging this pull request may close these issues.

Should UUID be a valid RefType?
2 participants
@vkarpov15 @hasezoey