Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index.d.ts): fix typings in Group stage #11124

Merged
merged 1 commit into from
Dec 21, 2021
Merged

fix(index.d.ts): fix typings in Group stage #11124

merged 1 commit into from
Dec 21, 2021

Conversation

DavideViolante
Copy link
Contributor

@DavideViolante DavideViolante commented Dec 20, 2021

As discussed in #11059. Thanks to @rpenido @jeremyben.

Fixes #11059 and #11067.

TypeScripts experts reviews are appreciated.

@DavideViolante DavideViolante changed the title Fix TS typings in Group stage fix(index.d.ts): fix typings in Group stage Dec 20, 2021
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@vkarpov15 vkarpov15 added this to the 6.1.3 milestone Dec 21, 2021
@vkarpov15 vkarpov15 merged commit 33792d1 into Automattic:master Dec 21, 2021
@DavideViolante DavideViolante deleted the patch-2 branch December 22, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript: Group interface for type PipelineStage has conflicting index signatures
2 participants