Follow-up fix of TS index signature definition for Group type. #11140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All explicitly defined keys should always follow the type defined at the index signature. So having `any` as a type for `_id` was just a hidden error. Even more, `_id` as a key in the member of union type was redundant.
|
@vkarpov15 please, take a quick look once you have a chance🙂 |
|
It seems correct, my snippets from #11059 works with this changes too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the follow-up PR for: #11059 and for #11124
All explicitly defined keys should always follow the type defined at the index signature. So having
anyas a type for_idwas just a hidden error.Even more,
_idas a key in the member of union type was redundant.