Fix problem when deleting an entry on a populated Map

[futurliberta]

Summary

I had a bug when deleting an entry from a populated Map.

Examples

import mongoose, { Schema } from 'mongoose';
import connectToDatabase from '@/server/libs/database/mongoose';

await connectToDatabase();

const playerSchema = new mongoose.Schema({
  name: String,
});

const PlayerModel = mongoose.model('PlayerTest', playerSchema);

const characterSchema = new mongoose.Schema({
  name: String,
  items: [{
    type: Schema.Types.ObjectId,
    ref: 'ItemTest',
  }],
});

const CharacterModel = mongoose.model('CharacterTest', characterSchema);

const itemSchema = new mongoose.Schema({
  name: String,
});

const ItemModel = mongoose.model('ItemTest', itemSchema);

const gameSchema = new mongoose.Schema({
  characters: {
    type: Map,
    of: {
      type: Schema.Types.ObjectId,
      ref: 'CharacterTest',
    },
    required: true,
  },
});

const GameModel = mongoose.model('GameTest', gameSchema);

const playerTest = await PlayerModel.create({ name: 'Player 1' });
const itemTest = await ItemModel.create({ name: 'Item 1' });
const characterTest = await CharacterModel.create({
  name: 'Character 1',
  items: [itemTest],
});

const gameTest = await GameModel.create({
  characters: {
    [playerTest.id]: characterTest,
  },
});

await gameTest.populate('characters');

console.log(gameTest.characters);

try {
  gameTest.characters.delete(playerTest.id); // <-- This will throw an error
  console.log('Deleted character from game');
} catch (err) {
  console.error(err); // TypeError: Cannot read properties of undefined (reading '$__')
}

[futurliberta]

There is probably a better fix to do because of the value is undefined, we can probably skip a lot of checks

[vkarpov15]

Thanks 👍