Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem when deleting an entry on a populated Map #14654

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Fix problem when deleting an entry on a populated Map #14654

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e4023f
Fix problem when deleting an entry on a populated Map
futurliberta Jun 8, 2024
26ab76a
remove unnecessary comment
vkarpov15 Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/types/map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class MongooseMap extends Map {
v.$__.wasPopulated = { value: v._id };
return v;
});
} else {
} else if (value) { // Fix when using delete method because the value is undefined
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is probably a better fix to do because of the value is undefined, we can probably skip a lot of checks

if (value.$__ == null) {
value = new populated.options[populateModelSymbol](value);
}
Expand Down