Add alternate and minimal styles to donate block #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adekbadek
requested changes
Mar 16, 2022
There was a problem hiding this comment.
If more than one payment method is available, the buttons are misaligned:
For comparison, here's master:
This can be emulated by adding another button in the .stripe-payment__methods element via browser devtools or in the PHP code.
Fixed in d3751c7 |
|
In fbe9d44 I've added a new "Minimal" style (updating PR desc/testing) |
thomasguillot
changed the title
matticbot
pushed a commit
that referenced
this pull request
Mar 31, 2022
# [1.47.0-alpha.1](v1.46.1...v1.47.0-alpha.1) (2022-03-31) ### Bug Fixes * **author-list:** handle alphabetizing last names containing spaces ([#1057](#1057)) ([1af7e19](1af7e19)) * authors and guest authors in homepage posts ([#1083](#1083)) ([038d9a4](038d9a4)) * donate block non-default styles grid breakpoint ([#1078](#1078)) ([5450e57](5450e57)) * **homepage-posts:** post fetch for widget blocks ([#1066](#1066)) ([3734a3f](3734a3f)) ### Features * add alternate and minimal styles to donate block ([#1068](#1068)) ([3c914d2](3c914d2))
|
🎉 This PR is included in version 1.47.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Apr 5, 2022
# [1.47.0](v1.46.1...v1.47.0) (2022-04-05) ### Bug Fixes * **author-list:** handle alphabetizing last names containing spaces ([#1057](#1057)) ([1af7e19](1af7e19)) * authors and guest authors in homepage posts ([#1083](#1083)) ([038d9a4](038d9a4)) * donate block non-default styles grid breakpoint ([#1078](#1078)) ([5450e57](5450e57)) * **homepage-posts:** post fetch for widget blocks ([#1066](#1066)) ([3734a3f](3734a3f)) * incorrect nesting of tax_query args ([#1087](#1087)) ([a613874](a613874)) ### Features * add alternate and minimal styles to donate block ([#1068](#1068)) ([3c914d2](3c914d2))
|
🎉 This PR is included in version 1.47.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR adds 2 new styles to the Donate Block: "Alternate" and "Minimal"
Default style
Alternate style (using Newspack as the Reader Revenue platform)
Alternate style (using Stripe as the Reader Revenue platform)
Minimal style (using Newspack as the Reader Revenue platform)
Minimal style (using Stripe as the Reader Revenue platform)
How to test the changes in this Pull Request:
Other information: