Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage Posts Block: Re-add excerpt length preview in editor #1247

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR re-adds the excerpt length preview that was accidentally removed in #1083.

Closes #1094.

How to test the changes in this Pull Request:

  1. Add the Homepage Posts block to the editor, and change the excerpt length.
  2. Note that the block reloads (becomes semi-transparent) but the excerpt length doesn't change -- however, if you publish your changes the new excerpt length will work on the front-end.
  3. Apply this PR.
  4. Confirm that if you change excerpt length, it now previews correctly in the editor.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford
Copy link
Contributor Author

Thanks @adekbadek!

@laurelfulford laurelfulford merged commit bdbe86e into master Aug 19, 2022
@laurelfulford laurelfulford deleted the fix/1094-excerpt-length-preview branch August 19, 2022 15:09
matticbot pushed a commit that referenced this pull request Aug 26, 2022
# [1.57.0-alpha.1](v1.56.0...v1.57.0-alpha.1) (2022-08-26)

### Bug Fixes

* add button block class to the Homepage Posts more button ([#1252](#1252)) ([c4d565c](c4d565c))
* disambiguate users and guest authors in Author List exclusions ([#1154](#1154)) ([c59056b](c59056b))
* **donate:** default value not below minimum donation ([#1248](#1248)) ([368e856](368e856))
* **donate:** use first & last name as default name ([#1255](#1255)) ([105d95b](105d95b))
* re-add excerpt length preview in editor ([#1247](#1247)) ([bdbe86e](bdbe86e))

### Features

* handle minimum donation option in Donate block ([#1239](#1239)) ([10dfefe](10dfefe))
* if donation via a prompt, add prompt ID to Stripe payment metadata ([#1253](#1253)) ([b8cb0e9](b8cb0e9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.57.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Sep 14, 2022
# [1.57.0](v1.56.0...v1.57.0) (2022-09-14)

### Bug Fixes

* add button block class to the Homepage Posts more button ([#1252](#1252)) ([c4d565c](c4d565c))
* correct Donate thank you message alignment ([#1258](#1258)) ([e838e61](e838e61))
* disambiguate users and guest authors in Author List exclusions ([#1154](#1154)) ([c59056b](c59056b))
* **donate:** default value not below minimum donation ([#1248](#1248)) ([368e856](368e856))
* **donate:** use first & last name as default name ([#1255](#1255)) ([105d95b](105d95b))
* re-add excerpt length preview in editor ([#1247](#1247)) ([bdbe86e](bdbe86e))
* update Homepage Posts grid spacing and add control  ([#1245](#1245)) ([9fa6972](9fa6972))

### Features

* handle minimum donation option in Donate block ([#1239](#1239)) ([10dfefe](10dfefe))
* if donation via a prompt, add prompt ID to Stripe payment metadata ([#1253](#1253)) ([b8cb0e9](b8cb0e9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage Posts Block: Excerpt length preview no longer works
3 participants