fix(donate): default value not below minimum donation #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
requested changes
Aug 19, 2022
|
Done in adcc731 |
dkoo
requested changes
Aug 22, 2022
|
Whoops! Sorry about the back and forth! Should be fixed by a4a3e6b |
dkoo
approved these changes
Aug 25, 2022
matticbot
pushed a commit
that referenced
this pull request
Aug 26, 2022
# [1.57.0-alpha.1](v1.56.0...v1.57.0-alpha.1) (2022-08-26) ### Bug Fixes * add button block class to the Homepage Posts more button ([#1252](#1252)) ([c4d565c](c4d565c)) * disambiguate users and guest authors in Author List exclusions ([#1154](#1154)) ([c59056b](c59056b)) * **donate:** default value not below minimum donation ([#1248](#1248)) ([368e856](368e856)) * **donate:** use first & last name as default name ([#1255](#1255)) ([105d95b](105d95b)) * re-add excerpt length preview in editor ([#1247](#1247)) ([bdbe86e](bdbe86e)) ### Features * handle minimum donation option in Donate block ([#1239](#1239)) ([10dfefe](10dfefe)) * if donation via a prompt, add prompt ID to Stripe payment metadata ([#1253](#1253)) ([b8cb0e9](b8cb0e9))
|
🎉 This PR is included in version 1.57.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Sep 14, 2022
# [1.57.0](v1.56.0...v1.57.0) (2022-09-14) ### Bug Fixes * add button block class to the Homepage Posts more button ([#1252](#1252)) ([c4d565c](c4d565c)) * correct Donate thank you message alignment ([#1258](#1258)) ([e838e61](e838e61)) * disambiguate users and guest authors in Author List exclusions ([#1154](#1154)) ([c59056b](c59056b)) * **donate:** default value not below minimum donation ([#1248](#1248)) ([368e856](368e856)) * **donate:** use first & last name as default name ([#1255](#1255)) ([105d95b](105d95b)) * re-add excerpt length preview in editor ([#1247](#1247)) ([bdbe86e](bdbe86e)) * update Homepage Posts grid spacing and add control ([#1245](#1245)) ([9fa6972](9fa6972)) ### Features * handle minimum donation option in Donate block ([#1239](#1239)) ([10dfefe](10dfefe)) * if donation via a prompt, add prompt ID to Stripe payment metadata ([#1253](#1253)) ([b8cb0e9](b8cb0e9))
|
🎉 This PR is included in version 1.57.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR sets the default value rendered on the block to never be below the configured minimum. It would be unintuitive for the donor not to be able to donate with the proposed value on the form.
Although the settings can be saved with a lower value, the displayed warning should be enough to let the user know that it may not behave as expected.
How to test the changes in this Pull Request:
Other information: