Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle minimum donation option in Donate block #1239

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Aug 15, 2022

All Submissions:

Changes proposed in this Pull Request:

Handles the new "minimum donation" setting from Automattic/newspack-plugin#1895 in the Donate block front-end and editor.

Closes #1211 and Automattic/newspack-plugin#1886.

How to test the changes in this Pull Request:

See testing instructions in Automattic/newspack-plugin#1895.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added enhancement New feature or request [Status] Needs Review labels Aug 15, 2022
@dkoo dkoo self-assigned this Aug 15, 2022
@dkoo dkoo marked this pull request as ready for review August 15, 2022 19:02
@dkoo dkoo requested a review from a team as a code owner August 15, 2022 19:02
src/blocks/donate/streamlined/index.ts Outdated Show resolved Hide resolved
src/blocks/donate/edit.tsx Outdated Show resolved Hide resolved
@dkoo dkoo requested a review from adekbadek August 16, 2022 17:20
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, since only a CSS tweak is needed.

src/blocks/donate/edit.tsx Show resolved Hide resolved
@dkoo
Copy link
Contributor Author

dkoo commented Aug 17, 2022

Awaiting approval of Automattic/newspack-plugin#1895.

@dkoo dkoo merged commit 10dfefe into master Aug 18, 2022
@dkoo dkoo deleted the feat/minimum-donation-option branch August 18, 2022 15:05
matticbot pushed a commit that referenced this pull request Aug 26, 2022
# [1.57.0-alpha.1](v1.56.0...v1.57.0-alpha.1) (2022-08-26)

### Bug Fixes

* add button block class to the Homepage Posts more button ([#1252](#1252)) ([c4d565c](c4d565c))
* disambiguate users and guest authors in Author List exclusions ([#1154](#1154)) ([c59056b](c59056b))
* **donate:** default value not below minimum donation ([#1248](#1248)) ([368e856](368e856))
* **donate:** use first & last name as default name ([#1255](#1255)) ([105d95b](105d95b))
* re-add excerpt length preview in editor ([#1247](#1247)) ([bdbe86e](bdbe86e))

### Features

* handle minimum donation option in Donate block ([#1239](#1239)) ([10dfefe](10dfefe))
* if donation via a prompt, add prompt ID to Stripe payment metadata ([#1253](#1253)) ([b8cb0e9](b8cb0e9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.57.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Sep 14, 2022
# [1.57.0](v1.56.0...v1.57.0) (2022-09-14)

### Bug Fixes

* add button block class to the Homepage Posts more button ([#1252](#1252)) ([c4d565c](c4d565c))
* correct Donate thank you message alignment ([#1258](#1258)) ([e838e61](e838e61))
* disambiguate users and guest authors in Author List exclusions ([#1154](#1154)) ([c59056b](c59056b))
* **donate:** default value not below minimum donation ([#1248](#1248)) ([368e856](368e856))
* **donate:** use first & last name as default name ([#1255](#1255)) ([105d95b](105d95b))
* re-add excerpt length preview in editor ([#1247](#1247)) ([bdbe86e](bdbe86e))
* update Homepage Posts grid spacing and add control  ([#1245](#1245)) ([9fa6972](9fa6972))

### Features

* handle minimum donation option in Donate block ([#1239](#1239)) ([10dfefe](10dfefe))
* if donation via a prompt, add prompt ID to Stripe payment metadata ([#1253](#1253)) ([b8cb0e9](b8cb0e9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Donate Block (streamlined): Include an option to set a minimum amount
3 participants