Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attribute types for custom author fields #1365

Merged
merged 1 commit into from
Feb 15, 2023
Merged

fix: attribute types for custom author fields #1365

merged 1 commit into from
Feb 15, 2023

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Feb 3, 2023

All Submissions:

Changes proposed in this Pull Request:

Fixes a type issue that causes custom Author Profile and Author List fields to be displayed on the front-end even if those fields are disabled in the editor. The string type of the attribute forces the rendered value to always be truthy.

Closes 1203695565716937/1203810977425531.

How to test the changes in this Pull Request:

  1. Add an Author Profile and Author List block to a post. Add guest authors who have custom fields filled out (Job Title, Role, Employer, Phone Number)
  2. Uncheck some of the fields and observe that they're hidden in the editor, but not on the front-end.
  3. Check out this branch and confirm that only the checked fields are shown in both the editor and the front-end.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added bug Something isn't working [Status] Needs Review labels Feb 3, 2023
@dkoo dkoo requested a review from a team as a code owner February 3, 2023 19:35
@dkoo dkoo self-assigned this Feb 3, 2023
@dkoo dkoo merged commit 483e49c into master Feb 15, 2023
@dkoo dkoo deleted the fix/author-fields-attribute-type branch February 15, 2023 20:33
matticbot pushed a commit that referenced this pull request Feb 17, 2023
@semantic-release-bot
chore(release): 1.63.0-alpha.1 [skip ci]
e41a1cd 
# [1.63.0-alpha.1](v1.62.0...v1.63.0-alpha.1) (2023-02-17)

### Bug Fixes

* attribute types for custom author fields ([#1365](#1365)) ([483e49c](483e49c))
* remove mark background in Newspack blocks ([#1363](#1363)) ([295b7d1](295b7d1))

### Features

* **donate-block:** native wc subs ([#1359](#1359)) ([9834aa0](9834aa0))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.63.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 28, 2023
@semantic-release-bot
chore(release): 1.63.0 [skip ci]
fecd28b 
# [1.63.0](v1.62.0...v1.63.0) (2023-02-28)

### Bug Fixes

* attribute types for custom author fields ([#1365](#1365)) ([483e49c](483e49c))
* remove mark background in Newspack blocks ([#1363](#1363)) ([295b7d1](295b7d1))

### Features

* **donate-block:** native wc subs ([#1359](#1359)) ([9834aa0](9834aa0))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.63.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees

@dkoo dkoo

Labels
bug Something isn't working released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkoo @matticbot @adekbadek